Ticket #7227 (closed: fixed)
SCDCalibratePanel fails to retain preprocessed L0 parameter
Reported by: | Ruth Mikkelson | Owned by: | Ruth Mikkelson |
---|---|---|---|
Priority: | major | Milestone: | Release 2.6 |
Component: | Diffraction | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Vickie Lynch |
Description
Attachments
Change History
comment:1 Changed 7 years ago by Ruth Mikkelson
- Status changed from new to accepted
- Owner set to Ruth Mikkelson
comment:2 Changed 7 years ago by Ruth Mikkelson
Refs #7227 Added code to return the "preprocessed" L0
Changeset: e1c0a80d3126a858fde809cc9731c27125f2af2e
comment:3 Changed 7 years ago by Ruth Mikkelson
Refs #7227 Doxygen ,documentation, and Cpp check changes
Couldn't find new ticket number for these
Changeset: f427be15fe2a2979e355d18cdc09eacdc9c6794d
comment:4 Changed 7 years ago by Ruth Mikkelson
Refs #7227 Fixed doxygen errors
Changeset: 35e6355b410b2a1ce9283c5c8b8fdced8dad7d72
comment:5 Changed 7 years ago by Ruth Mikkelson
Refs #7227 Fixed another doxygen error
Changeset: c3e7cb312ec0e4fd7da920bbf8cbf0c705b693a6
comment:6 Changed 7 years ago by Ruth Mikkelson
- Status changed from accepted to verify
- Resolution set to fixed
Tester:
Should test before and after to see change:
Steps:
Load Attached Peaks file FindUBUsingFFT minD=3, maxD=12, tolerance =.12 Index Peaks SelectCellByType Rhombohedral R Index Peaks again Round 1st)SCDCalibratePanels abc,alpha,...= 4.785,4.785,12.991,90,90,120
no preprocessing, check L0 ,det width and height. DetCal file=xxx.DetCal, output =Result1
2nd) process with xxx.DetCal check only det position. DetCal file=xxx1.DetCal output=Result2
Check that L0 for Result2 agrees with L0 for Result1( or look at the DetCal files). The Detwidth and
heights should also agree.
comment:7 Changed 7 years ago by Vickie Lynch
- Status changed from verify to verifying
- Tester set to Vickie Lynch
comment:8 Changed 7 years ago by Vickie Lynch
- Status changed from verifying to closed
Works exactly as described so I am passing ticket. Things that could be improved in another ticket if you have time:
Add the string "Err" in front of the parameter names for the error rows instead of the word Error above Save errors from first optimization as well as values Python generated script history does not have which parameters were optimized saved so all are done
comment:11 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8073