Ticket #7235 (closed: fixed)
Remove legacy REFM and SANS algorithms
| Reported by: | Mathieu Doucet | Owned by: | Mathieu Doucet |
|---|---|---|---|
| Priority: | major | Milestone: | Release 2.6 |
| Component: | Framework | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #7260 | Tester: | Michael Reuter |
Description (last modified by Nick Draper) (diff)
Remove the following algorithms that are no longer in use:
1- RefEstimates: python algorithm using the old API. Was used in REFM demo but not used.
Will need to remove it from the script generation in the GUI (refm_data_script.py).
2- EQSANSTransmission: python algorithm using the old API. This old method of computing the transmission has not been in use for years.
3- LoadNISTSANS: old demo algorithm that was never used in production.
Change History
comment:2 Changed 7 years ago by Mathieu Doucet
Re #7235 removed obsolete code
Changeset: 793ae80d6ec5bd86301cdc923618c9aa6561d835
comment:3 Changed 7 years ago by Mathieu Doucet
Re #7235 remove old tests
Changeset: 1565064ce070700b6ea4c32d1af4ada5d450ff78
comment:4 Changed 7 years ago by Mathieu Doucet
- Status changed from accepted to verify
- Resolution set to fixed
To Test: check that the old code is gone and that reference to it doesn't exist in the Mantid code.
comment:5 Changed 7 years ago by Mathieu Doucet
- Status changed from verify to reopened
- Resolution fixed deleted
comment:7 Changed 7 years ago by Mathieu Doucet
- Status changed from accepted to verify
- Resolution set to fixed
comment:9 Changed 7 years ago by Michael Reuter
- Status changed from verify to verifying
- Tester set to Michael Reuter
comment:10 Changed 7 years ago by Michael Reuter
- Status changed from verifying to reopened
- Resolution fixed deleted
Missed a reference to LoadNISTSANS in Code/Mantid/scripts/reduction/instruments/sans/ngsans_instrument.py.
comment:11 Changed 7 years ago by Mathieu Doucet
Re #7235 Remove unused ngsans code
Changeset: 70c95bc654542d7643b5be1220fb3a58e4ae0413
comment:13 Changed 7 years ago by Mathieu Doucet
- Status changed from accepted to verify
- Resolution set to fixed
Should now be fine. I removed twp NGSANS files in scripts/reduction.
comment:15 Changed 7 years ago by Michael Reuter
- Status changed from verifying to closed
All the requested functions/files have been removed.
comment:17 Changed 7 years ago by Nick Draper
- Component changed from Framework to SANS
- Description modified (diff)
comment:19 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8081
