Ticket #7245 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Remove qtassistant from the "all" target

Reported by: Peter Peterson Owned by: Peter Peterson
Priority: major Milestone: Release 2.6
Component: Tools Keywords:
Cc: martyn.gigg@…, campbellsi@… Blocked By:
Blocking: Tester: Mathieu Doucet

Description (last modified by Nick Draper) (diff)

There are two parts to this:

  1. Remove qtassistant from all
  2. Reconfigure build servers to "make qtassistant" before "make package" otherwise everything will be broken

Step 2. will have to be done when this is merged into develop, and again when merged into master.

Change History

comment:1 Changed 7 years ago by Peter Peterson

Re #7245. Removing qtassistant from the all target.

Changeset: e06d7f8d9a62db8d217a57494efb2b9ef2272046

comment:2 Changed 7 years ago by Peter Peterson

Merge branch 'feature/7245_remove_qtassistant_from_all' into develop

Conflicts:

Code/Mantid/docs/qtassistant/CMakeLists.txt

Re #7245.

Changeset: 2aeeb09b22357582b85edbdc93ace8d2ba4136e2

comment:3 Changed 7 years ago by Peter Peterson

  • Status changed from new to accepted
  • Owner set to Peter Peterson

comment:4 Changed 7 years ago by Peter Peterson

  • Status changed from accepted to verify
  • Resolution set to fixed

This is on ​feature/7245_remove_qtassistant_from_all.

To test (​pedantic method):

  1. create a new build area
  2. cmake -DENABLE_QTASSISTANT=True -DENABLE_CPACK=True
  3. Confirm that make (with default target) doesn't create qtassistant files (in bin/qtassistant/html), "make package" should also fail
  4. "make qtassistant" should generate the qtassistant files and rerunning "make package" should also succeed.

comment:5 Changed 7 years ago by Mathieu Doucet

  • Status changed from verify to verifying
  • Tester set to Mathieu Doucet

comment:6 Changed 7 years ago by Mathieu Doucet

  • Status changed from verifying to closed

comment:7 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:8 Changed 7 years ago by Nick Draper

  • Component changed from Framework to Tools
  • Description modified (diff)

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8091

Note: See TracTickets for help on using tickets.