Ticket #7253 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Improvements to workspace groups and dock

Reported by: Roman Tolchenov Owned by: Roman Tolchenov
Priority: critical Milestone: Release 2.6
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Gesner Passos

Description (last modified by Roman Tolchenov) (diff)

These changes should simplify the use of workspace groups:

  • Groups work only with pointers, not names
  • Groups don't remove workspaces from the ADS
  • ADS should return its tree view for the dock to display

Change History

comment:1 Changed 7 years ago by Roman Tolchenov

  • Status changed from new to accepted

comment:2 Changed 7 years ago by Roman Tolchenov

Workspace's setName method is made private. Tests are still failing.

Re #7253

Changeset: 106e30d2609a73b7e4098435702d2850012fd801

comment:3 Changed 7 years ago by Roman Tolchenov

All unit tests pass after making setName private. Re #7253

Changeset: b8dd98ce96941529d007ce7d0342a387a5698b4d

comment:4 Changed 7 years ago by Roman Tolchenov

Workspace's setName method is made private. Tests are still failing.

Re #7253

Changeset: f45f593444dfc1be23c8dec184e2d56e5745f18c

comment:5 Changed 7 years ago by Roman Tolchenov

All unit tests pass after making setName private. Re #7253

Changeset: ba31aeac2581153cc4235ad3c708c6ef0b9ee9ab

comment:6 Changed 7 years ago by Roman Tolchenov

A correction after rebase. Re #7253

Changeset: 75067c6da3abc32dac5f1fb9cc64ba146775520d

comment:7 Changed 7 years ago by Roman Tolchenov

Change to VATES which should fix the develop build. Re #7253

Changeset: 75e6a708f82df2715b45eb39644fd767dac21a28

comment:8 Changed 7 years ago by Roman Tolchenov

Changed the VATES tests so they don't use setName(). Re #7253

Changeset: 6ed6dc7cf2ae5a790c516e6f3040dd21c0e5ddc1

comment:9 Changed 7 years ago by Roman Tolchenov

This should fix the windows tests. Re #7253

Changeset: 3aec29ebc4b8f9f7a834859ce68d0d4d6cfb8102

comment:10 Changed 7 years ago by Roman Tolchenov

Moved deep group removing to the ADS class. Re #7253.

Changeset: 2b0087c606d7823f1a6f4fbe7e654c06a9aa5b0a

comment:11 Changed 7 years ago by Roman Tolchenov

WorkspaceGroup removes by name via the ADS. Re #7253

Changeset: b76db08630146c608a188427cb31107cede640bf

comment:12 Changed 7 years ago by Roman Tolchenov

WorkspaceGroup's add and remove methods use ADS to do the job.

Re #7253

Changeset: f1beb624ed95abf9469ffc87dca4095008f21f89

comment:13 Changed 7 years ago by Roman Tolchenov

  • Description modified (diff)

comment:14 Changed 7 years ago by Roman Tolchenov

Hidden observeADSnotifications switch in WorkspaceGroup. Re #7253.

Changeset: 1c5fb65fd45ef60a90c50fcc78e681f66d386f25

comment:15 Changed 7 years ago by Roman Tolchenov

  • Description modified (diff)

comment:16 Changed 7 years ago by Roman Tolchenov

Refactored the dock widget to use the info tree from the ADS. Re #7253

Changeset: 9412934d68f47de0cd7ba309b44f216e6a3e8a3b

comment:17 Changed 7 years ago by Roman Tolchenov

Correction to a unit test. Re #7253

Changeset: 14736a7bbff314ad2e0d4076ffcb5f712315a4b2

comment:18 Changed 7 years ago by Roman Tolchenov

Windows builds need the dll export macro. Re #7253.

Changeset: 0b2907bb1c7c37cd3fd8a049d0df31c4fecc9140

comment:19 Changed 7 years ago by Roman Tolchenov

More tests added. Reopen tree items after update.

Re #7253.

Changeset: c133062bec86e2872c05b5bd81e9195b72f0ae0d

comment:20 Changed 7 years ago by Roman Tolchenov

Small correction to a test. Re #7253

Changeset: 889cf9fb457d1aaa4ac12c6be4944faf673a0d91

comment:21 Changed 7 years ago by Roman Tolchenov

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:22 Changed 7 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:23 Changed 7 years ago by Nick Draper

Good by my testing, although I have not checked the system test status. 

Clone of a group --pass
clone of a member --pass
pairwise group sum --pass
sum of group to 1ws --pass
delete 1 group member --pass
form a group from group member and 1 ungrouped --pass
delete of group --pass (note cascading deletes)

comment:24 Changed 7 years ago by Owen Arnold

  • Status changed from verifying to reopened
  • Resolution fixed deleted

This looks ok by me too, but It'd be better if the merge conflicts were solved on the actual branch. That's the only reason that I'm reopening this ticket. Make sure that your version of master is up to date, and merge it into this branch, then solve conflict, then checkbuild, then close the ticket again.

comment:25 Changed 7 years ago by Roman Tolchenov

Merge branch 'master' into feature/7253_workspace_groups_and_dock

Conflicts:

Code/Mantid/Framework/WorkflowAlgorithms/src/AlignAndFocusPowder.cpp

Re #7253

Changeset: fe478a4716fbae81a6ff31d4dbffea086682cbca

comment:26 Changed 7 years ago by Roman Tolchenov

  • Status changed from reopened to accepted

comment:27 Changed 7 years ago by Roman Tolchenov

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:28 Changed 7 years ago by Gesner Passos

  • Status changed from verify to verifying
  • Tester changed from Owen Arnold to Gesner Passos

comment:29 Changed 7 years ago by Gesner Passos

  • Status changed from verifying to closed

working nicelly

comment:30 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:31 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8099

Note: See TracTickets for help on using tickets.