Ticket #7291 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

PlotAsymmetryByLogValue uses workspace index instead of spectra id.

Reported by: Roman Tolchenov Owned by: Roman Tolchenov
Priority: critical Milestone: Release 2.6
Component: Muon Keywords:
Cc: Blocked By:
Blocking: Tester: Alex Buts

Description (last modified by Nick Draper) (diff)

  • When Forward and Backward lists contain single number they are interpreted as workspace indices instead of spectra ids.
  • Also allow run_number log to be used

Change History

comment:1 Changed 7 years ago by Roman Tolchenov

  • Status changed from new to accepted

comment:2 Changed 7 years ago by Roman Tolchenov

  • Description modified (diff)

comment:3 Changed 7 years ago by Roman Tolchenov

Convert spectra ids to ws indices in AsymmetryCalc. Re #7291.

Changeset: 85997046a702bf101e0ab8139d85dfcef935262e

comment:4 Changed 7 years ago by Roman Tolchenov

Use all types of logs that can be converted to double. Re #7291

Changeset: f395b2453c5ee64c99b661f22b60085ea835079f

comment:5 Changed 7 years ago by Roman Tolchenov

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:6 Changed 7 years ago by Alex Buts

  • Status changed from verify to verifying
  • Tester set to Alex Buts

comment:7 Changed 7 years ago by Alex Buts

  • Status changed from verifying to closed

Minor issues:

if one (presumably erroneously) provides forward spectra as 0, algorithm complains with strange message:

Workspace2D::getSpectrum, histogram number 319500960 out of range 64.

if one provides 0,2 which is also wrong, algorithm happily accepts that and plots something.

I hope this make sense for a specialist

All other points were tested by running from GUI so I am not sure if spectra numbers are really correct, though looks plausible.

comment:8 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:9 Changed 7 years ago by Nick Draper

  • Component changed from Framework to Muon
  • Description modified (diff)

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 8137

Note: See TracTickets for help on using tickets.