Ticket #7299 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Add testing for Material::parseChemicalFormula

Reported by: Peter Peterson Owned by: Peter Peterson
Priority: major Milestone: Release 2.6
Component: Framework Keywords:
Cc: lynchve@… Blocked By:
Blocking: Tester: Mathieu Doucet

Description

This method does not currently have any unit tests.

Change History

comment:1 Changed 7 years ago by Peter Peterson

  • Status changed from new to accepted

comment:2 Changed 7 years ago by Peter Peterson

Re #7299. Added a bunch of tests for Material.

Still on the list of things to do is to return actual atoms which will bring more of the error checking into a single location.

Changeset: d62b3a629c6916495a1b9c2fa8d94422ec6e12aa

comment:3 Changed 7 years ago by Peter Peterson

  • Status changed from accepted to verify
  • Resolution set to fixed

This is on ​feature/7299_material_tests.

Since the ticket is to add unit tests, check that there are some and that they pass when you run them. It should be noted that some of the chemical formulas specified are nonsense, but the parser doesn't confirm that they aren't.

comment:4 Changed 7 years ago by Mathieu Doucet

  • Status changed from verify to verifying
  • Tester set to Mathieu Doucet

comment:5 Changed 7 years ago by Mathieu Doucet

  • Status changed from verifying to closed

The test exists, and it passes.

comment:6 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8145

Note: See TracTickets for help on using tickets.