Ticket #7303 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Broken PeakTransform Identification

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: major Milestone: Release 2.6
Component: Framework Keywords:
Cc: Blocked By:
Blocking: #7281 Tester: Peter Peterson

Description (last modified by Nick Draper) (diff)

Pete found an issue relating to the PeakTransform identification. This has been lined to 7281, but issue is actually already present in master. See comment 13 in #7281.

Problem appears to be down to how the PeakTransform for QLab space identifies itself. I'm going to add some unit tests to prevent this error slipping through the net again, for all Peaktransform types.

To reproduce.

  • Create an MDWorkspace with coordinates in QLab
  • Load or create a PeaksWorkspace
  • Show the MDWorkspace and the PeaksWorkspace in the SliceViewer.
  • On the top RHS of the SliceViewer, just above the peaks list is a label called "Coordinates", this is incorrectly reading "QLab".

Change History

comment:1 Changed 7 years ago by Owen Arnold

  • Status changed from new to accepted

comment:2 Changed 7 years ago by Owen Arnold

refs #7303. Fix naming. Add tests.

Changeset: b3b154d8516f204898c914110a7ba9961ec326cf

comment:3 Changed 7 years ago by Owen Arnold

branch feature/7303_peak_identification

comment:4 Changed 7 years ago by Owen Arnold

  • Status changed from accepted to verify
  • Resolution set to fixed

Tester: Check out the scenario described in the description before applying changes, then apply changes to observe that this has been fixed.

comment:5 Changed 7 years ago by Peter Peterson

  • Status changed from verify to verifying
  • Tester set to Peter Peterson

comment:6 Changed 7 years ago by Peter Peterson

  • Status changed from verifying to closed

comment:7 Changed 7 years ago by Nick Draper

  • Component changed from VATES to Framework
  • Description modified (diff)

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8149

Note: See TracTickets for help on using tickets.