Ticket #7319 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Get the ISIS reflectometry l2q.py under test.

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: major Milestone: Release 2.6
Component: Reflectometry Keywords:
Cc: Blocked By:
Blocking: #7317 Tester: Anders Markvardsen

Description

Similar requirement here for l2q as for quick. See #7317. Since quick uses l2q. Makes sense to get this sorted first.

Change History

comment:1 Changed 7 years ago by Owen Arnold

  • Status changed from new to accepted

refs #7319. Move scripts out of package for testability.

Changeset: e6f500649cee5194502f1c2eeee47d9ba729ad04

Last edited 7 years ago by Owen Arnold (previous) (diff)

comment:2 Changed 7 years ago by Owen Arnold

refs #7319. Move l2q to new API, but make callable from quick.

Changeset: 39429d73c39c8751729e267039c64a074cdcc801

comment:3 Changed 7 years ago by Owen Arnold

Tester: System test called L2QScriptTest should be running and passing on the development system tests.

There are two branches here that need to go into master. Add them into master in the order listed.

in the mantid repository: feature/7319_l2q_testing

in the systemtest repository: feature/7319_l2q_testing

It should be sufficient that the system tests pass, but you may also want to verify that the relocation and tweaking of the user generated scripts has not broken the reflectometry GUI. For this, I can provide some example data. Best contact me directly to do this.

Last edited 7 years ago by Owen Arnold (previous) (diff)

comment:4 Changed 7 years ago by Owen Arnold

refs #7319. Remove imports from inside package init instead.

Changeset: df70070173e05788d1ceb13fe190b74ca182b522

comment:5 Changed 7 years ago by Owen Arnold

refs #7319. System test and results added.

Changeset: 30eb6754096c13c053395316b4cad2824c5de6ae

comment:6 Changed 7 years ago by Owen Arnold

refs #7319. Sort out imports.

Changeset: 01c0d5687f0a9d01ee5340fdc9c3108e1315c2ca

comment:7 Changed 7 years ago by Owen Arnold

refs #7319. Merge branch 'feature/7319_l2q_testing' into develop

Changeset: 75b62846bcf42d79cc587df4d435ad8c62fbd045

comment:8 Changed 7 years ago by Owen Arnold

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:9 Changed 7 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester set to Anders Markvardsen

comment:10 Changed 7 years ago by Anders Markvardsen

  • Status changed from verifying to closed

ISIS reflectometry l2q.py has been put under test

comment:11 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:12 Changed 7 years ago by Nick Draper

  • Component changed from Framework to Reflectometry

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8165

Note: See TracTickets for help on using tickets.