Ticket #7321 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Change version numbering for nightly and unstable

Reported by: Peter Peterson Owned by: Peter Peterson
Priority: major Milestone: Release 3.0
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Jay Rainey

Description (last modified by Peter Peterson) (diff)

For both of these an incremental number does not make as much sense. Especially since currently the patch number is the number of commits since the last tag which occasionally resets on develop (goes backwards). The suggestion is to use ​ISO8601 strings to set the version. There are ​extra variables to set in CMake. The will be set to:

  • VERSION_MAJOR - same as current stable release
  • VERSION_MINOR - same as current stable release
  • VERSION_PATCH - date of build in GMT formatted as YYYYMMDD.HHMM

This would mean that last nights build would have the version "2.5.20130618.2303" (built Jun 19, 2013 12:03:25 AM at ISIS).

Change History

comment:1 Changed 7 years ago by Peter Peterson

  • Description modified (diff)

comment:2 Changed 7 years ago by Nick Draper

  • Owner changed from Nick Draper to Peter Peterson
  • Status changed from new to assigned

I think we agreed on 2.5.20130618-2303

comment:3 Changed 7 years ago by Nick Draper

  • Status changed from assigned to new

comment:4 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:5 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Backlog

Moved to backlog at the code freeze for R2.6

comment:6 Changed 7 years ago by Peter Peterson

  • Description modified (diff)
  • Milestone changed from Backlog to Release 3.0

comment:7 Changed 7 years ago by Peter Peterson

  • Status changed from new to inprogress

comment:8 Changed 7 years ago by Peter Peterson

  • Description modified (diff)

Turns out that I misunderstood the variables understood in CMAKE.

comment:9 Changed 7 years ago by Peter Peterson

Re #7321. Added more git properties to cmake.

Changeset: 51de457e34334958d9cf52e9aabb430454cd1875

comment:10 Changed 7 years ago by Peter Peterson

Re #7321. Changed patch version to be the new long string in package.

Changeset: 373cd34be8a1229053ab88cb978b894df2f52054

comment:11 Changed 7 years ago by Peter Peterson

Re #7321. Unified mantid version and added extra git attr.

Changeset: a8667fa65d7e83add8099b293e8f737c8468d00c

comment:12 Changed 7 years ago by Peter Peterson

Re #7321. Split out revision info in about dialog.

Changeset: 16d74683d526a6e7daa09ef9365aa58a23dd7b45

comment:13 Changed 7 years ago by Peter Peterson

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is in ​feature/7321_patch_version_number.

To test:

  1. Startup mantid and not the version it reports
  2. Look at the version information in the Help->About dialog
  3. Test the github link in the Help->About dialog which should open a link in your web browser to a page that is a 404 since you haven't pushed your merge to origin.

comment:14 Changed 7 years ago by Jay Rainey

  • Status changed from verify to verifying
  • Tester set to Jay Rainey

comment:15 Changed 7 years ago by Jay Rainey

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/7321_patch_version_number'

comment:16 Changed 7 years ago by Jay Rainey

Testing

  • The version number now makes more sense (Producing 2.6.20130816.1502 for me, as expected).
  • Produces version number as described at each step in comment:13.
  • Tested on Ubuntu 12.04

Code review

  • Well written code with no notable issues.

comment:17 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8167

Note: See TracTickets for help on using tickets.