Ticket #7336 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

SNSPowderReduction also reduces removed low resolution TOF data

Reported by: Wenduo Zhou Owned by: Wenduo Zhou
Priority: critical Milestone: Release 2.6
Component: Diffraction Keywords:
Cc: petersonpf@… Blocked By: #7362
Blocking: Tester: Peter Peterson

Description (last modified by Peter Peterson) (diff)

Current SNSPowderReduction removes and discards the low resolution TOF data.

The instrument scientists of POGEN requires to save the removed low resolution TOF data in an extra workspace, align and focus it similar to the high resolution TOF data.

Conjoin the low resolution workspace to OutputWorkspace as an additional spectrum with spectrum ID shifted by an offset specified by user.

Attachments

ticket7336a.2.py (1.4 KB) - added by Wenduo Zhou 7 years ago.
ticket7336a.py (1.4 KB) - added by Wenduo Zhou 7 years ago.
ticket7336b.py (1.6 KB) - added by Wenduo Zhou 7 years ago.
compare01.png (584.9 KB) - added by Wenduo Zhou 7 years ago.
compare02.png (589.3 KB) - added by Wenduo Zhou 7 years ago.

Change History

comment:1 Changed 7 years ago by Wenduo Zhou

  • Status changed from new to accepted

comment:2 Changed 7 years ago by Wenduo Zhou

  • Priority changed from major to critical
  • Description modified (diff)

comment:3 Changed 7 years ago by Wenduo Zhou

  • Blocked By 7362 added

comment:4 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #7336.

Expanded AlignAndFocusPowder to reduce low resolution data in addition.

Changeset: 10debb9e2e8ed0d55005d876aa63f7d6546b2c5c

comment:5 Changed 7 years ago by Wenduo Zhou

Make SNSPowderReduction to support low resolution TOF. Refs #7336.

Changeset: 0d8b6d62a606ca5d28d921ec917eb0fc903d00db

comment:6 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #7336.

Changeset: ec591236444bf8dbfdafccd9833eadfd281a1e5c

comment:7 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #7336.

  1. Conjoin the low resolution TOF workspace to output workspace;
  2. Enable to use offset on spectrum number of the spectra from low

resolution TOF workspace;

  1. Refactor codes

Changeset: 824bf42cb4385732ef0994a751a00771301f998b

comment:8 Changed 7 years ago by Wenduo Zhou

Modified SNSPowderReduction for low resolution. Refs #7336.

Changeset: 95afa427bb70db97a32e975237e470d0d81736e0

comment:9 Changed 7 years ago by Wenduo Zhou

Intended to catch a segmentation fault. Refs #7336.

Changeset: dcfb99677f4e06b109fc79415cbd76f920149158

comment:10 Changed 7 years ago by Wenduo Zhou

Added check on some input vectors size. Refs #7336.

Changeset: 518e245e3cddec58deaf0a132ff7bcc8e32d41a3

comment:11 Changed 7 years ago by Wenduo Zhou

Fixed an error. Refs #7336.

Changeset: 03f1f26b4e4fd167e67b6b06cac757aa5e7962ce

comment:12 Changed 7 years ago by Wenduo Zhou

  • Description modified (diff)

Changed 7 years ago by Wenduo Zhou

Changed 7 years ago by Wenduo Zhou

Changed 7 years ago by Wenduo Zhou

comment:13 Changed 7 years ago by Wenduo Zhou

Fixed the gold file for system test. Refs #7336.

Changeset: 92ed568ec2d180ec8f03d9d0bbae0c80ac7a44f7

Attached compare01.png and compare02.png show the difference between the previous golden file and the new one.

Last edited 7 years ago by Wenduo Zhou (previous) (diff)

comment:14 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #7336.

Changeset: 656452765b035732b1ae9f5c5698749a4280b388

comment:15 Changed 7 years ago by Wenduo Zhou

Fixed the system test and a memory leak. Refs #7336.

Changeset: 51e9bff4e3524cbfc28c06b83ff4e1d95de0d905

comment:16 Changed 7 years ago by Wenduo Zhou

Add an information output. Refs #7336.

Changeset: c03f95a8ae201873ffd926c005aa794d26893db8

comment:17 Changed 7 years ago by Wenduo Zhou

Cleaned the code. Refs #7336.

Changeset: d44b1bf6a54556d8c44fd1370a028452f614d7ab

Changed 7 years ago by Wenduo Zhou

Changed 7 years ago by Wenduo Zhou

comment:18 Changed 7 years ago by Wenduo Zhou

  • Description modified (diff)

comment:19 Changed 7 years ago by Wenduo Zhou

  • Status changed from accepted to verify
  • Resolution set to fixed

Instruction for verifying

  1. Download test script (ticket7336a.py) and locate all the files required by it;
  1. Run the script and you will get a reduced workspace with 1 spectrum;
  1. Set the value of LowResSpectrumOffset to a positive value such as 2;
  1. Run the script again. Then you can get a reduced workspace with 2 spectra. Spectrum number 1 is just same as the one obtained in step 2. And spectrum number 4 (if you set offset to 2) is the low resolution diffraction pattern.
  1. Download test script (ticket7336b.py) and locate all the files required by it;
  1. Run the script and you will get a reduced workspace with 2 spectrum;
  1. 'Show detectors' to check the detectors are of the same values specified in the characterization file.

comment:20 Changed 7 years ago by Peter Peterson

  • Status changed from verify to verifying
  • Tester set to Peter Peterson

comment:21 Changed 7 years ago by Peter Peterson

  • Blocking 7470 added

comment:21 Changed 7 years ago by Peter Peterson

  • Status changed from verifying to reopened
  • Resolution fixed deleted
  • Blocking 7470 removed
  • Description modified (diff)

This works as expected except for one significant detail: the spectrum offset is not used in an expected way. On a random POWGEN data (13428) focused to a single spectrum (common) I used an offset of "7" and got output spectra of "1" and "9". It should be "1" and "8". Simlarly, setting the offset to "1" gives "1" and "3" as the output spectra. It appears that there is an extra "+1" in the code.

I also created #7470 as a related task.

comment:22 Changed 7 years ago by Wenduo Zhou

  • Status changed from reopened to verify
  • Resolution set to fixed

comment:24 Changed 7 years ago by Wenduo Zhou

Fixed the reported issue. Refs #7336.

Changeset: 1ad0b0d5f858f8bc0bf0cb642289545c496dcade

comment:25 Changed 7 years ago by Peter Peterson

  • Status changed from verify to verifying

comment:26 Changed 7 years ago by Peter Peterson

  • Status changed from verifying to closed

comment:27 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:28 Changed 7 years ago by Nick Draper

  • Component changed from Framework to Diffraction

comment:29 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 8182

Note: See TracTickets for help on using tickets.