Pressing on ScatterPlot Mode in Vates Simple interface kills Manitd

[Alex Buts]

Observed on win64.

If one brings VATES simple interface and presses Scatter Plot Mode, Mantid dies.

Problem signature:
  Problem Event Name:	APPCRASH
  Application Name:	MantidPlot.exe
  Application Version:	0.0.0.0
  Application Timestamp:	51c47dd0
  Fault Module Name:	vtkpqCore-pv3.98.dll
  Fault Module Version:	0.0.0.0
  Fault Module Timestamp:	519121f8
  Exception Code:	c0000005
  Exception Offset:	0000000000017000
  OS Version:	6.1.7601.2.1.0.256.48
  Locale ID:	2057
  Additional Information 1:	d2d6
  Additional Information 2:	d2d6bd5cdaed5b564ee1af4859e89114
  Additional Information 3:	b265
  Additional Information 4:	b265b6629a8315dcece7239b6386069e

It may be something to do with scary message recently started to come during compilation (see below). As I remember, coord_t is Real*4 and double Real*8 so nasty problems may be expected.

40>C:/Mantid/Code/Third_Party/include\boost/smart_ptr/make_shared.hpp(443): warning C4244: 'argument' : conversion from 'double' to 'Mantid::coord_t', possible loss of data (C:\Mantid\Code\Mantid\Vates\VatesAPI\src\LoadVTK.cpp)
40>          C:\Mantid\Code\Mantid\Vates\VatesAPI\src\LoadVTK.cpp(300) : see reference to function template instantiation 'boost::shared_ptr<T> boost::make_shared<Mantid::Geometry::MDHistoDimension,const char(&)[2],const char(&)[2],const char(&)[1],double&,double&,int&>(A1,A2,A3,A4,A5,A6)' being compiled
40>          with
40>          [
40>              T=Mantid::Geometry::MDHistoDimension,
40>              A1=const char (&)[2],
40>              A2=const char (&)[2],
40>              A3=const char (&)[1],
40>              A4=double &,
40>              A5=double &,
40>              A6=int &
40>          ]

[Michael Reuter]

What dataset (file) is causing the problem? The code giving the compilation issue is not used by the VSI at all. I run the SplatterPlot mode all the time, so it must be a particular dataset.

[Alex Buts]

File demonstrating this behaviour on Win-7 is not big (4.8M) but still exceeds the download limit allowed here.

Until our FTP server is dead, please try to take it from Libisis server where it will stay for a week:

​​http://download.libisis.org/kits/MAP1104MD.nxs

[Michael Reuter]

I got the file. Thanks.

[Michael Reuter]

OK, now I understand. The SplatterPlot view does not handle 4D data. For now, I will use this ticket to not allow 4D in SplatterPlot, but I've opened #7429 to investigate handling 4D data in SplatterPlot.

[Michael Reuter]

Refs #7339. Throwing exception in factory for 4D data.

Changeset: 5571e9f92e24c474b7c83367d4e61c4bae74cdf3

[Michael Reuter]

Refs #7339. Changing dimension check.

Changeset: 4765110f3b2dcbfd9c0c2a64a592a1b9995cb1d8

[Michael Reuter]

Refs #7339. Stopping 4D data from being used in SplatterPlot.

Changeset: 0330432c77c59b05902d2c5a02c63dc4b0194486

[Michael Reuter]

The branch can be found ​here.

To test: Use the file above or SEQ_MDEW.nxs to test.

1. Open the file in Mantid and view the MDWorkspace in the VSI
2. Switch to SplatterPlot view

The program should show a warning dialog saying that you need 3D data in order to use the SplatterPlot view. The VSI will switch back to the Standard view. Test further by executing SliceMD on the workspace in MantidPlot and integrate the 4th dimension. Viewing the resulting workspace in the VSI should work.

[Alex Buts]

yes, it sorts the crash problem but it is really important to solve #7429 as one may often want to see 4D data in splatter mode.

[Stuart Campbell]

This ticket has been transferred to github issue ​8185