Ticket #7343 (closed: fixed)
SaveMask improvements
| Reported by: | Nick Draper | Owned by: | Nick Draper |
|---|---|---|---|
| Priority: | major | Milestone: | Release 2.6 |
| Component: | Framework | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Roman Tolchenov |
Description (last modified by Nick Draper) (diff)
- If the workspace is a matrix workspace it should use extractMasking to get the mask out.
- The GroupedDetectors property only leads to optional an unnecessary exceoptions, Remove it.
This may lead to some issues with the signiture changing, but we have to deal with it as no-one understands the GroupedDetectors option. And looking at the code it is not worth the characters it is written in.
Change History
comment:1 Changed 7 years ago by Nick Draper
- Status changed from new to accepted
- Description modified (diff)
- Summary changed from SaveMask should work on matrixworkspaces to SaveMask improvements
comment:2 Changed 7 years ago by Nick Draper
re #7343 savemask removed GoupedDetectors param & allow matrixWS
Changeset: f8bdebc37d7a7393d3d0b37480ff43a366383961
comment:3 Changed 7 years ago by Nick Draper
re #7343 sorting out pointless merge conflicts
Changeset: f83d2d697bdef73166a168bc7a8a3628f7848803
comment:4 Changed 7 years ago by Nick Draper
To test:
- Check that unit tests and system tests pass
- Load a workspace W1
- use the instrumentview to mask some data, note the absence of the groupeddetectors checkbox
- Run extractMask on the masked matrix workspace W1 to create W2.
- Run SaveMask on W1 and W2 seperately. The files should be pretty much equivalent.
comment:5 Changed 7 years ago by Nick Draper
- Status changed from accepted to verify
- Resolution set to fixed
comment:6 Changed 7 years ago by Nick Draper
re #7343 sorting out pointless merge conflicts
Changeset: b295ba710419cbf5717a6747bb69ded28e6d2c6b
comment:7 Changed 7 years ago by Martyn Gigg
Enable some masking tests for WISH now that SaveMask is fixed.
Refs #7343
Changeset: 0c0c01a63a5fa355cd779bee27de8bbe6bc75398
comment:8 Changed 7 years ago by Martyn Gigg
The WishMasking.py system test also needed updating as a result of these changes. The branch "feature/7343_savemask_should_extract" is in both the main code & system test repositories. Both need to be merged when testing this ticket.
comment:9 Changed 7 years ago by Roman Tolchenov
- Status changed from verify to verifying
- Tester set to Roman Tolchenov
comment:12 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8189
