Ticket #7360 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Make sure HFIR SANS can save output

Reported by: Mathieu Doucet Owned by: Mathieu Doucet
Priority: major Milestone: Release 2.6
Component: SANS Keywords:
Cc: Blocked By:
Blocking: Tester: Russell Taylor

Description

The new version of the HFIR reduction (using the new python API) doesn't save the output workspaces to file as it should.

Attachments

biosans_test.xml​ (19.7 KB) - added by Mathieu Doucet 7 years ago.

Change History

Changed 7 years ago by Mathieu Doucet

comment:1 Changed 7 years ago by Mathieu Doucet

  • Status changed from new to accepted

To test:

  • Start the ORNL SANS UI
  • Make sure systemtests/Data and systemtests/Data/SANS2D are in your search directories
  • Load the XML file in attachment.
  • Hit Reduce.
  • Output files should be saved in systemtests/Data

comment:2 Changed 7 years ago by Mathieu Doucet

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:3 Changed 7 years ago by Mathieu Doucet

Re #7360 Fix problem with output files

Changeset: bdf3658092949634c7cf5b042f435bf96c88a175

comment:4 Changed 7 years ago by Mathieu Doucet

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:5 Changed 7 years ago by Mathieu Doucet

Re #7360 Fix problem with output files

Changeset: ae40bd5075f786058cb7d5138e5f9741891cca47

comment:6 Changed 7 years ago by Mathieu Doucet

  • Status changed from reopened to accepted

comment:7 Changed 7 years ago by Mathieu Doucet

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:8 Changed 7 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:9 Changed 7 years ago by Russell Taylor

I don't see any saved workspaces even after the change. Could they be somewhere else that I haven't thought of looking, or is there something missing from the instructions?

comment:10 Changed 7 years ago by Russell Taylor

  • Status changed from verifying to reopened
  • Resolution fixed deleted

Mathieu says, "You are right. It only works if you give a full path for the data file. Otherwise it doesn't work."

That is indeed the case for me too.

comment:11 Changed 7 years ago by Mathieu Doucet

Re #7360 Fix problem with output when no output dir specified

Changeset: cd3ba53c26f3e19f1171053504077885ee597480

comment:12 Changed 7 years ago by Mathieu Doucet

  • Status changed from reopened to accepted

It should now work. Please test with both a single file in the "sample data" field, and with two files separated by a comma. (You can use the same file twice.)

comment:13 Changed 7 years ago by Mathieu Doucet

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:14 Changed 7 years ago by Russell Taylor

  • Status changed from verify to verifying

comment:15 Changed 7 years ago by Russell Taylor

Merge remote branch 'origin/feature/7360_fix_hfir_output'. Re #7360.

Conflicts:

Code/Mantid/scripts/reduction_workflow/instruments/sans/hfir_command_interface.py

Changeset: 901ec8ceb9ee0b104187ba5fcb0ebe97eb626fd9

comment:16 Changed 7 years ago by Russell Taylor

  • Status changed from verifying to closed

It works now - I get 3 files saved into the same directory as the data file: BioSANS_test_data_Iq.txt, BioSANS_test_data_Iq.xml & BioSANS_test_data_Iqxy.dat

The merge conflict was an empty line.

comment:17 Changed 7 years ago by Nick Draper

  • Component changed from Framework to SANS

comment:18 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8206

Note: See TracTickets for help on using tickets.