Ticket #7363 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Keep VATES code running with latest ParaView

Reported by: Michael Reuter Owned by: Steven Hahn
Priority: major Milestone: Backlog
Component: GUI Keywords:
Cc: Blocked By:
Blocking: Tester: Stuart Campbell

Description

I've decided to make a ticket to ensure that the VATES code all compiles and runs against the latest ParaView from their git repo. This will allow us to see things coming down the line.

Change History

comment:1 Changed 7 years ago by Michael Reuter

  • Status changed from new to accepted

comment:2 Changed 7 years ago by Michael Reuter

Refs #7363. Getting thing to compile.

Changeset: cfe8630b1bdab4d11bf55e3777a9f29bb54412dc

comment:3 Changed 7 years ago by Michael Reuter

Refs #7363. Taking out missing slot.

Changeset: 695c9e0472a8aea6bd25df0d8d96ef78145bfe4e

comment:4 Changed 7 years ago by Nick Draper

  • Status changed from accepted to assigned

comment:5 Changed 7 years ago by Nick Draper

  • Status changed from assigned to new

comment:6 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.7 to Backlog

comment:7 Changed 7 years ago by Nick Draper

  • Component changed from VATES to User Interface

comment:8 Changed 7 years ago by Michael Reuter

  • Status changed from new to inprogress

Refs #7363. Conforming readers to new XML layout.

The new XML layout for readers moves the file extensions into a Hints section in the main XML. The GUI XML is no longer necessary, I think.

Changeset: 9ebf75e6e3716e2cb95b6e7e9d227ee602f9fb51

comment:9 Changed 7 years ago by Michael Reuter

Refs #7363. Fixing issue with PV crashing due to Python.

Changeset: 161df5b0b254a98c61b249143782d07bd0c4b3c9

comment:10 Changed 7 years ago by Michael Reuter

Refs #7363. Removing connection removal.

Performing the initial connection removal now results in the Display part of the Property panel to not appear. Removing this call brings it back.

Changeset: f3a46b1d4b2d436ba6183dd16271143acded608b

comment:11 Changed 7 years ago by Michael Reuter

Refs #7363. Make sure python stuff is available, if not used.

Changeset: 912efe429d9e71f59176c48e9fd177540ce37acb

comment:12 Changed 7 years ago by Nick Draper

  • Milestone changed from Backlog to Release 3.0

moved to Release 3.0 as these all seem to be active

comment:13 Changed 7 years ago by Michael Reuter

  • Milestone changed from Release 3.0 to Release 3.1

comment:14 Changed 7 years ago by Michael Reuter

  • Milestone changed from Release 3.1 to Release 3.2

comment:15 Changed 7 years ago by Michael Reuter

Refs #7363. Forgot to change ParaView version in cmake.

Changeset: 1d2fe18f7c2ec1626bd4f403fc7867affe2dd793

comment:16 Changed 7 years ago by Michael Reuter

Refs #7363. Bringing color map editor back.

Changeset: 5ada41df9c6df1365b395cafc76b443925e86b09

comment:17 Changed 7 years ago by Michael Reuter

Refs #7363. Fixing color range warnings for peaks workspaces.

Changeset: 8667e553a5581dba587be3ee918f11759d51eb43

comment:18 Changed 7 years ago by Michael Reuter

Refs #7363. Fixing crash issue on Windows when closing the VSI.

A big thanks to Martyn and Owen for tracking this one down!

Changeset: 7e8fd848bd0ca70245aff5d5043e19659843c8f7

comment:19 Changed 6 years ago by Michael Reuter

Refs #7363. Tweaks to build scripts for ParaView next.

Changeset: 4fbef8bcd70aaf5e483975d10d12fdbd7f63a69a

comment:20 Changed 6 years ago by Michael Reuter

Refs #7363. Changing pvnext handling for packaging vars.

Changeset: acd431ffc6d7b332c1d0de74b7e3b3e6e05e61f0

comment:21 Changed 6 years ago by Michael Reuter

Refs #7363. Windoze doesn't override env vars well.

Changeset: 25a61d9d9b5f381e61222fbbd284068564fc5f8f

comment:22 Changed 6 years ago by Michael Reuter

Refs #7363. Forgot to fix a variable.

Changeset: 1aa486e0791e0625cf1529305abe953c867af613

comment:23 Changed 6 years ago by Michael Reuter

Refs #7363. Fix linux/osx script?.

Changeset: 710fd89691afc8a5e46f98d3ad34e59a34001681

comment:24 Changed 6 years ago by Michael Reuter

Refs #7363. Fix linux/osx script.

Changeset: b1fb400dcbdd4642916c6ff6f393572b7a46d3fe

comment:25 Changed 6 years ago by Michael Reuter

Refs #7363. Trying to figure out why Windoze script doesn't work.

Changeset: 42932bca173ad36a4d2882c4f8f3a5b31d373dcd

comment:26 Changed 6 years ago by Michael Reuter

Refs #7363. Forgot symbol.

Changeset: 2eafc5d00af2d7490a72b8fa151cc369fd721b48

comment:27 Changed 6 years ago by Michael Reuter

Refs #7363. More debugging.

Changeset: 9c255c4f7abd1e73a5ede08c338867be809b2fe7

comment:28 Changed 6 years ago by Michael Reuter

Refs #7363. Fixing Windoze script.

Changeset: c45cf86370cfb48a2b2bda3df646d60105502e3a

comment:29 Changed 6 years ago by Michael Reuter

Refs #7363. Fixing Windoze script.

Changeset: d2c20ed41534cb96fb7410bad6c195faf4fc65e2

comment:30 Changed 6 years ago by Michael Reuter

Refs #7363. Removing debugging and adding build type variable.

Changeset: 3a5c1591fa23562d00826a01226a64d8a5efbf2b

comment:31 Changed 6 years ago by Michael Reuter

Refs #7363. Trying to make Windows debug package work.

Changeset: 4ebf5f7302093c17b038151bab03a9b5f61a3934

comment:32 Changed 6 years ago by Michael Reuter

Refs #7363. Debugging script.

Changeset: 78fbd29dfcf83fbb53fbb550b70276409c55f4c4

comment:33 Changed 6 years ago by Michael Reuter

Revert "Refs #7363. Debugging script."

This reverts commit 78fbd29dfcf83fbb53fbb550b70276409c55f4c4.

Changeset: a028fd03070d45e6a1d2894e501ebc78e947c0fd

comment:34 Changed 6 years ago by Michael Reuter

Revert "Refs #7363. Trying to make Windows debug package work."

This reverts commit 4ebf5f7302093c17b038151bab03a9b5f61a3934.

Changeset: 9c9fce4a8afc2be933ac785a5e82412132cc00ad

comment:35 Changed 6 years ago by Michael Reuter

Refs #7363. Merge branch 'master' into feature/7363_vates_paraview_git

Conflicts:

Code/Mantid/Build/Jenkins/buildscript.bat

Changeset: 870cd36e0e159dd3af6c0dbe43d7fec6ad878c59

comment:36 Changed 6 years ago by Michael Reuter

  • Milestone changed from Release 3.2 to Release 3.3

comment:37 Changed 6 years ago by Michael Reuter

Refs #7363. Fixing conflicts.

Merge branch 'master' into feature/7363_vates_paraview_git

Conflicts:

Code/Mantid/Build/Jenkins/buildscript Code/Mantid/Build/Jenkins/buildscript.bat

Changeset: 73914cd3fa1af3bedfb737d4c115b002ca28f128

comment:38 Changed 6 years ago by Michael Reuter

Refs #7363. TIME_LABEL_ANNOTATION switched classes.

Changeset: 27b9cffe0097bf005e39e8690847fc9c220dc7b8

comment:39 Changed 6 years ago by Michael Reuter

Refs #7363. Fixing CMake policy issues.

Changeset: fc3c05718773d36e89b1954a0cb7043d5494f4de

comment:40 Changed 6 years ago by Michael Reuter

Refs #7363. Fixing SaveScreenshotReaction.

Changeset: a6db14e4326c422d8397f396154ece7b5041c1c0

comment:41 Changed 6 years ago by Michael Reuter

Refs #7363. Update ParaView behaviors.

Changeset: d77cf4f4f64e29a6a7bd32a951caf5c57ecaec54

comment:42 Changed 6 years ago by Michael Reuter

Refs #7363. Switching to different reaction for view settings.

Changeset: 6a7885f70eccc669b846a05bf51b7fb0b2e52c23

comment:43 Changed 6 years ago by Michael Reuter

Refs #7363. Fixing last compliation errors.

Changeset: 1de1839d9922bbb32c13fa467d47f8727b3f8cc6

comment:44 Changed 6 years ago by Michael Reuter

Refs #7363. Making things "work".

The new ParaView has really messed up the carefully orchestrated mechanisms of the VSI. Serious rewriting is going to have to take place to put things back together again. Sigh.

Changeset: 28e46e4f850e96f1e22504251f152fcb6d699664

comment:45 Changed 6 years ago by Michael Reuter

Refs #7363. Adding include to make clang happy.

Changeset: 09ee36156ef9ea1d26684c70edfa715a12b40b56

comment:46 Changed 6 years ago by Michael Reuter

Refs #7363. Update to next release version.

Changeset: ca01b2754a7d0fe9de4bfc84c8fdfa56e0379358

comment:47 Changed 6 years ago by Michael Reuter

Refs #7363. Version number regex adjustment.

Makes the regex handle things like 4.2.0-RC1-32-g1771379. Now package can find correct installed version.

Changeset: 49022554398390ac99d132bb18f832d8310ccffc

comment:48 Changed 6 years ago by Michael Reuter

Refs #7363. Separate Info.plist variables.

To avoid ambiguity in library calls, set the Info.plist variables for either build or kit variants.

Changeset: 0782c0b1eb05308ac611f127ae55ff08b88f8767

comment:49 Changed 6 years ago by Michael Reuter

Refs #7363. Add second check on job name for OSX 10.9.

Changeset: 59453f4deed96ef548748524fea8f48a93355dcc

comment:50 Changed 6 years ago by Michael Reuter

Refs #7363. Use node label instead.

Changeset: 05fe7c2f4e983d1dbf84761cbd47647140ce82ca

comment:51 Changed 6 years ago by Michael Reuter

Refs #7363. Go back to job name.

Changeset: 84f383ba126f17a8492fc9e1a92d18d8649e28f4

comment:52 Changed 6 years ago by Michael Reuter

Refs #7363. Specifically linking to new libraries.

Making Windows happy by specifically linking to libraries that OSX and Linux just find.

Changeset: 6771de7e92faf3a513143de28a946cbefd479973

comment:53 Changed 6 years ago by Michael Reuter

Refs #7363. Disable MantidPlot tests.

The build server brian has issues with the tests. Temporarily disable running them so a package can be made.

Changeset: d1886c006f4b01d83be4705e831598db016fe9d7

comment:54 Changed 6 years ago by Michael Reuter

Refs #7363. Quieting compiler warnings on modern GCC.

Changeset: f1a2a190b5d186355758c53532f2f90ffde68a90

comment:55 Changed 6 years ago by Michael Reuter

Refs #7363. Correcting name for QuadView.

Changeset: 1738029bc384dd73441c7ae03af51eac1da959de

comment:56 Changed 6 years ago by Nick Draper

Moved to the backlog at the code freeze of R3.3

comment:57 Changed 6 years ago by Nick Draper

  • Milestone changed from Release 3.3 to Backlog

comment:58 Changed 6 years ago by Steven Hahn

Refs #7363. Merge remote-tracking branch 'origin/master'

Conflicts:

Code/Mantid/Build/Jenkins/buildscript.bat

Changeset: 3b5146f06aa274a19a1d5b48a8dcb17561c894c0

comment:59 Changed 6 years ago by Steven Hahn

Refs #7363. Creating new Properties panel

Changeset: cfcca5db2a51d6f9f53eb9296d1d334596559be1

comment:60 Changed 6 years ago by Steven Hahn

Refs #7363. Fix apply and delete buttons.

Changeset: ec685934ef05c0a3148ffe72d59b18e8d8235f25

comment:61 Changed 6 years ago by Steven Hahn

Refs #7363. change cut from SliceView

Changeset: 2ab748d04dd507425d6bff08fc2ab7b3b7c28f7c

comment:62 Changed 6 years ago by Steven Hahn

Refs #7363. multiple VATES windows

Changeset: 2149a0930887b3a48ed5a1d56e1a6bf27892dc29

comment:63 Changed 6 years ago by Steven Hahn

Refs #7363. Change to vtkStructuredGrid.

Changeset: 72faff79311ca4875e42f16b0be38e911a44a4ad

comment:64 Changed 6 years ago by Steven Hahn

Refs #7363. Set Active view to current view

Changeset: c8f2504c6130de9d615e9adc1cf395f935edc551

comment:65 Changed 6 years ago by Pete Peterson

Re #7363. clang-format

Changeset: 6c97de90d5a5035bb6279a5c378a78a154fee84f

comment:66 Changed 6 years ago by Steven Hahn

  • Owner changed from Michael Reuter to Steven Hahn

comment:67 Changed 6 years ago by Steven Hahn

Refs #7363. running clang-format.

Changeset: 248f353907de2ef2a9375e3676e4ea37987640fe

comment:68 Changed 6 years ago by Steven Hahn

Refs #7363. Changes required to successfully compile Mantid.

Changeset: dada6b880a08f60800743df7ca101a92099b1aa2

comment:69 Changed 6 years ago by Steven Hahn

Refs #7363. Changes required to build with paraview 4.3

Changeset: 25df544473db2ef9899f0d2b3444725faf5faf48

comment:70 Changed 6 years ago by Steven Hahn

Refs #7363. Changes to build without errors or compiler warnings.

Changeset: 943c48dfd79a978572ff4862eeae131f41cdded3

comment:71 Changed 6 years ago by Utkarsh Ayachit

Refs #7363: Fix header file case name.

Changeset: da2655147d61a34ce726f8ea8ec534887a50cdfb

comment:72 Changed 6 years ago by Utkarsh Ayachit

Refs #7363: Use the new OrthographicSliceView instead of QuadView.

This removes the need to load the QuadView plugin since OrthographicSliceView is included in the ParaView library by default (not a separate plugin anymore).

Changeset: 25500fcb30467bae522600458e09e00e04a9dcb7

comment:73 Changed 6 years ago by Steven Hahn

Refs #7363. Change compatible paraview version.

Changeset: eb5654746e7757c9cbf140404d44b637819fe26c

comment:74 Changed 6 years ago by Steven Hahn

Refs #7363. Fixes to get mantid to build.

Changeset: da5f8ea0ea2714dd1b6481b0e91ad927cbd36137

comment:75 Changed 6 years ago by Steven Hahn

Refs #7363. Bundle paraview libraries inside Mantid package.

Changeset: 441ea6df8a00da7ac5b13d67fa00ce578eff7642

comment:76 Changed 6 years ago by Steven Hahn

Refs #7363. Paraview bundled and VATES starts and runs!

Changeset: ebb97c865b7b16a312d0d0949c91dc29a633c780

comment:77 Changed 6 years ago by Pete Peterson

Re #7363. Added cpack magic to include paraview and vtk in rpms.

Changeset: bb5ae1cd0f4c99a06069d71b0e8d5c9cbb256e92

comment:78 Changed 6 years ago by Pete Peterson

Re #7363. Depend on paraview libraries rather than runtime

Changeset: 31aed2424e3597ef91db005fb4ff25072ccb36e7

comment:79 Changed 6 years ago by Steven Hahn

Refs #7363. Add rpath within cmake

Changeset: b1d46be90d78efba87fe3fa2d8a4438e71b971e4

comment:80 Changed 6 years ago by Steven Hahn

Refs #7363. Set INSTALL_RPATH within cmake.

Changeset: a62f04f72b4db7db4f8c80e456539bb4084c3a52

comment:81 Changed 6 years ago by Steven Hahn

Refs #7363. RPATH already set within cmake.

Changeset: 194cc26ec56d53d5791cf0fe443a991da9ec3974

comment:82 Changed 6 years ago by Steven Hahn

Refs #7363. Fix missing RPATH.

Changeset: 0959e32a7fc77fe6d7671d04755244ba7a560bee

comment:83 Changed 6 years ago by Pete Peterson

Re #7363. Added INBUNDLE and full paraview

Changeset: e914c847a15e2473061dfb301138bed6b8e1018f

comment:84 Changed 6 years ago by Owen Arnold

refs #7363. Windows fixes for dev.

Before seeing how the bundling packaging worked out, I wanted to make sure that running PV the old way still worked and introduced a number of fixes along the way.

1) ParaView now returns 0 for success rather than 1

2) We need to explicitly put the PV_PLUGIN_PATH environment variable through via the vtk system utilities as it will not be picked up otherwise.

Changeset: c43bfde966ca4dac635b763a052aea6a119f5b52

comment:85 Changed 6 years ago by Pete Peterson

Re #7363. Adding hllibraries to bundle.

Changeset: 1f21aa6feda8ebdd61545b0af65ce90eb6a56cfa

comment:86 Changed 6 years ago by Martyn Gigg

Use MantidPlot exe path for ParaView core initialization.

An empty string causes a segfault. Refs #7363

Changeset: 2e38c77089eac5cc79dca2fb0762c5f58f54d87c

comment:87 Changed 6 years ago by Martyn Gigg

Fix a warning under -Wpedantic

Refs #7363

Changeset: 8628a5464c454c46d52848acf97b4418a1148e0c

comment:88 Changed 6 years ago by Steven Hahn

Refs #7363. Cleanup mac build script.

Changeset: 91a95f44d4280c64b2ab239e6826c32662fe22b6

comment:89 Changed 6 years ago by Steven Hahn

Refs #7363. Remove PARAVIEW_APP_DIR from DarwinSetup.cmake.

Changeset: 6e99e2df5c664f55939cb455c743e62b370809f5

comment:90 Changed 6 years ago by Martyn Gigg

Simplify setup for ParaView plugins.

All OSs should now go through the same procedure and only require the pvplugins.directory to be set for the VSI to work. Refs #7363

Changeset: 2e33e1aab5f1bf1542192cad5c8ed6086e42b2e1

comment:91 Changed 6 years ago by Owen Arnold

refs #7363. Win32 section not needed.

Changeset: ff72d7e17f7042cd055e7638d3ffc05e2b87f669

comment:92 Changed 6 years ago by Steven Hahn

Refs #7363. Fix build error and pedantic warnings on OSX

Changeset: 5c458e0f960d4d593919653233a8190ba2a0fc03

comment:93 Changed 6 years ago by Andrei Savici

Fix conversion warnings. Refs #7363

Changeset: a278230abb24c87c99746c34a292685c0fc72f1c

comment:94 Changed 6 years ago by Steven Hahn

Refs #7363. Make packaging script work when MAKE_VATES isn't enabled.

Changeset: a952b9cdcdf5307d70902085af14e9f9bedbc70a

comment:95 Changed 5 years ago by Martyn Gigg

Always use PARAVIEW_NEXT_DIR for ParaView when building

Refs #7363

Changeset: d19c43829ee3a42a59722258f173895eb8b6cba4

comment:96 Changed 5 years ago by Steven Hahn

Refs #7363. Suppress unused function warnings in testing header.

Changeset: 100633e8538af64ce6631fac0ba007de7efa7e86

comment:97 Changed 5 years ago by Steven Hahn

Refs #7363. Fix PV_PLUGINS location on OSX.

Changeset: 37a14aa568bc8494daba0f2e3947ac7dbf91df6d

comment:98 Changed 5 years ago by Steven Hahn

Refs #7363. Remove second properties panel.

Changeset: 71af81e9d534ea9a6ab6867032ba696b3ebe1361

comment:99 Changed 5 years ago by Steven Hahn

Refs #7363. Bring back pipeline browser.

Changeset: 11f59f2e3375a2923c8c39f826885a36953a7ba8

comment:100 Changed 5 years ago by Steven Hahn

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as pull request #582.

comment:101 Changed 5 years ago by Steven Hahn

Refs #7363. Fix cpp-check issues.

Changeset: 1695972a0286830a1ef7dd1f2864e9ffd0086f91

comment:102 Changed 5 years ago by Owen Arnold

refs #11502. refs #7363. Non orthogonal fixed.

Non-orthogonal representations fixed.

Conflicts:

Code/Mantid/Vates/VatesAPI/src/vtkDataSetToNonOrthogonalDataSet.cpp

Changeset: 8f702c27f384dac64482b54ae478a773df8d6842

comment:103 Changed 5 years ago by Steven Hahn

Refs #7363. Fix warnings on OSX.

Changeset: 98a00a8fd2dbd72a64a5118faad0e08ad521fae6

comment:104 Changed 5 years ago by Steven Hahn

Revert "Refs #7363. Change to vtkStructuredGrid."

This reverts commit 72faff79311ca4875e42f16b0be38e911a44a4ad.

Changeset: fd62599233114fb55338974a99dd7159bb7076a1

comment:105 Changed 5 years ago by Steven Hahn

Refs #7363. Fix multiple sources loaded at startup.

Changeset: 14e1b29fe828638266406694985bc6e5e812a963

comment:106 Changed 5 years ago by Steven Hahn

Refs #7363. Suppress OSX warnings without changing interface.

Changeset: a36c1af626208407de267788a948a9e9087ef6d0

comment:107 Changed 5 years ago by Steven Hahn

Refs #7363. Keep properties panel attached. Whitespace fix.

Changeset: 172afecb920f31e08c6829b3882bc1c4589a421b

comment:108 Changed 5 years ago by Steven Hahn

Refs #7363. CubeAxes set differently in PV 4p3.

Changeset: 55b928b42cb0606bf00fff9e769d15ed18f7d819

comment:109 Changed 5 years ago by Steven Hahn

Refs #7363. Cleanup empty member function.

Changeset: 2d70c634c726127c519d8f272de5bef5ca1ded7d

comment:110 Changed 5 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:111 Changed 5 years ago by Stuart Campbell

  • Tester changed from Andrei Savici to Stuart Campbell

comment:112 Changed 5 years ago by Stuart Campbell

Well, @quantumsteve tells me it's all ok - so I'll trust him! :anguished:

comment:113 Changed 5 years ago by Owen Arnold

  • Status changed from verifying to closed

Merge branch '7363_vates_paraview_4p3' of github.com:mantidproject/mantid into 7363_vates_paraview_4p3

Full changeset: e2701344c31fe155d4f3acd9381275759dee519b

comment:114 Changed 5 years ago by Anton Piccardo-Selg

Merge branch '7363_vates_paraview_4p3' of github.com:mantidproject/mantid into 7363_vates_paraview_4p3

Full changeset: 15193da5c4adb2fadbe1d3eff0e54b3307dcb478

comment:115 Changed 5 years ago by Stuart Campbell

Merge pull request #582 from mantidproject/7363_vates_paraview_4p3

Update VATES to use ParaView 4.3.1

Full changeset: 91880669613f4af2b2d8c71927d45f2a119312e3

comment:116 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 8209

Note: See TracTickets for help on using tickets.