In IDFs check all from dates later than 1900-01-31 23:59:01

[Anders Markvardsen]

Accidently found that if a data file load has a data matching a IDF with a from data prior to 1900-01-31 23:59:01 then the data file loads but not the IDF

In this ticket ensure that no from dates are earlier than 1900-01-31 23:59:01, which at least EMU_Definition_32detectors.xml has

[Anders Markvardsen]

A couple with invalid valid-from dates. re #7366

Changeset: 49310769ec8c424378d4e92ac139e9775564b942

[Anders Markvardsen]

Throw if valid-from not valid. re #7366

To help user and developer print a sensible message is valid-from date is too early

Changeset: a3ab9a78b6936a826a1a0fb4a0e2d6d6de2f9270

[Russell Taylor]

Note the warning (on all platforms I think) due to there being only one colon after 'Kernel' at Instrument.cpp line 1126:

Kernel:DateAndTime earliestAllowedDate("1900-01-31 23:59:01");

[Anders Markvardsen]

fix warning russell spotted. re #7366

Changeset: 98605c7e5cbd292d359191b92fa26165fdc92c90

[Anders Markvardsen]

To test check that unit tests and systemtests are passing

In instrument folder check that there are no IDF with a valid-from date earlier than 1900-01-31 23:59:01

[Keith Brown]

Tested that it throws with an invalid date having altered a valid file to become invalid then tried loading it. Reverted that edit and loaded it again having fixed the date back to how it was

LoadLotsOfInstruments test passed during the last build on is_test_rhel6_develop which was ran after the last commit for this branch so all instruments pass this test.

[Stuart Campbell]

This ticket has been transferred to github issue ​8212