Ticket #7392 (closed: fixed)
Write unit tests for WorkspaceOpOverloads/WorkspaceHelpers
| Reported by: | Russell Taylor | Owned by: | Russell Taylor |
|---|---|---|---|
| Priority: | critical | Milestone: | Release 3.0 |
| Component: | Framework | Keywords: | Maintenance |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Michael Reuter |
Description
The code in WorkspaceOpOverloads (including the WorkspaceHelpers namespace) is mostly not covered by unit tests.
Change History
comment:1 Changed 7 years ago by Nick Draper
- Status changed from new to assigned
- Owner set to Russell Taylor
comment:3 Changed 7 years ago by Nick Draper
- Priority changed from major to critical
- Keywords Maintenance added
comment:5 Changed 7 years ago by Russell Taylor
- Status changed from new to inprogress
It turns out that most of the operator overloads themselves are tested in the respective tests for Plus/Minus/Multiply/Divide. The exceptions are:
- operator+(workspace,number) - though this is tested in ComplexOpTest
- operator-(workspace,number) - called by nothing whatsoever!
- operator-(number,workspace) - ditto
- operator*(workspace,number)
- operator*(number,workspace)
- operator/(workspace,number) - though this is tested in ComplexOpTest
- operator/(number,workspace) - called by nothing whatsoever!
In fact, these functions need to be tested elsewhere so that they have access to the actual algorithms. The same goes for the equals function, which uses the CheckWorkspacesMatch and is tested in the test for that.
comment:6 Changed 7 years ago by Russell Taylor
Re #7392. Tests for binary algorithm operator overloads
...where one of the arguments is a number.
Changeset: 7e1b83090d3ff36e693495bfe5df2cbef769762f
comment:7 Changed 7 years ago by Russell Taylor
Re #7392. Test for WorkspaceHelpers::commonBoundaries.
Changeset: 322627decc858e38dc2608ed280519662c95b03e
comment:8 Changed 7 years ago by Russell Taylor
Re #7392. Test for WorkspaceHelpers::matchingBins.
Changeset: cb3315b714bdb899c547ba848a29aa279523d93e
comment:9 Changed 7 years ago by Russell Taylor
Re #7392. Test for WorkspaceHelpers::sharedXData.
Changeset: 0a052a5843774e45f107c4f5762124d39c1e7910
comment:10 Changed 7 years ago by Russell Taylor
Re #7392. Test for WorkspaceHelpers::makeDistribution.
Changeset: 2d6a8690b760c28f253827dd1b4cfefe9dcb6774
comment:11 Changed 7 years ago by Russell Taylor
- Status changed from inprogress to verify
- Resolution set to fixed
comment:12 Changed 7 years ago by Michael Reuter
- Status changed from verify to verifying
- Tester set to Michael Reuter
comment:13 Changed 7 years ago by Michael Reuter
All the code coverage requests have been fulfilled and the tests run fine on Ubuntu.
comment:14 Changed 7 years ago by Michael Reuter
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/7392_workspacehelpers_unit_tests'
comment:15 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8238
