Ticket #7396 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Unit Test for LoadIDFFromNexus

Reported by: Karl Palmen Owned by: Karl Palmen
Priority: critical Milestone: Release 3.1
Component: Framework Keywords: Maintenance
Cc: anders.markvardsen@… Blocked By:
Blocking: Tester: Owen Arnold

Description

There is no unit test for LoadIDFFromNexus. I expect such a test would require a short test file like the one used by LoadInstrumentFromRawTest.

Change History

comment:1 Changed 7 years ago by Karl Palmen

  • Status changed from new to assigned
  • Owner set to Karl Palmen

comment:2 Changed 7 years ago by Nick Draper

  • Status changed from assigned to new

comment:3 Changed 7 years ago by Nick Draper

  • Keywords Maintenance added
  • Priority changed from major to critical

comment:4 Changed 7 years ago by Karl Palmen

  • Milestone changed from Release 2.6 to Backlog

comment:5 Changed 7 years ago by Karl Palmen

  • Milestone changed from Backlog to Release 3.1

comment:6 Changed 7 years ago by Karl Palmen

  • Status changed from new to inprogress

comment:7 Changed 7 years ago by Karl Palmen

Create unit test re #7396

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 8d0aba93153a8a5cd861b14f7a079ae6afc0f251

comment:8 Changed 7 years ago by Karl Palmen

Tidy code and comments re #7396

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 39d49e74d029f90ad1ea4de7b085481953a6517d

comment:9 Changed 7 years ago by Karl Palmen

To test, check that the unit test does test the algorithm sufficiently well. To do this one can view the test file in HDF View or similar and look at the IDF in

mantid_workspace_1/instrument/instrument_xml/data

then check that the test is appropriate to this IDF.

comment:10 Changed 7 years ago by Karl Palmen

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:11 Changed 7 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:12 Changed 7 years ago by Owen Arnold

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/7396_unit_test_for_loadiffromnexus'

Full changeset: 451f56ff8cdbdebf1213b84e14a043418949d298

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 8242

Note: See TracTickets for help on using tickets.