Ticket #7398 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Create really non-throwing atom

Reported by: Alex Buts Owned by: Alex Buts
Priority: major Milestone: Release 2.6
Component: Framework Keywords:
Cc: lynchve@… Blocked By:
Blocking: Tester: Peter Peterson

Description

Current implementation of non-throwing atom implemented in mantid (and used during static atom instantiation) catches exception generated by normal atom.

It generates swarm of throw/catch events during Mantid start-up, which slows down the start-up process. It is especially annoying on windows in Debug mode where small Mantid submodule starts up to a minute due to all these throw/catch events generated when loading kernel as there are a lot of different atoms.

It is easy and beneficial to create non-throwing atom, which does not throw anything during instantiation.

Change History

comment:1 Changed 7 years ago by Alex Buts

  • Status changed from new to accepted

comment:2 Changed 7 years ago by Alex Buts

  • Status changed from accepted to verify
  • Cc lynchve@… added
  • Resolution set to fixed

The only commit to this ticket went with ref #6667

http://trac.mantidproject.org/mantid/changeset/0df38d27c4d410c0320cb96774a08ca3818b16d0/

and it is really trivial change making use of existing code.

Test may be done by code review or as all atom tests are currently passing and code based on the atoms works.

Or Vickie may just throw it away as has similar and more complex ticket to fix.

comment:3 Changed 7 years ago by Peter Peterson

  • Status changed from verify to verifying
  • Tester set to Peter Peterson

comment:4 Changed 7 years ago by Peter Peterson

  • Status changed from verifying to closed

comment:5 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 8244

Note: See TracTickets for help on using tickets.