Ticket #7400 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Clarify PeaksInRegion error message

Reported by: Michael Reuter Owned by: Owen Arnold
Priority: minor Milestone: Release 2.6
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

The segfault script in #7325 generates an error message (see same ticket). The last line leads one to believe more information can be retrieved. This does not seem to be the case as looking through the logs and changing log levels reveal nothing further. Either remove the extraneous message or add the extra information.

Change History

comment:1 Changed 7 years ago by Owen Arnold

  • Status changed from new to accepted

comment:2 Changed 7 years ago by Owen Arnold

refs #7400. Apply simple fix.

Changeset: df1189ef237bccc53ff79bd1c51e52a54e888c29

comment:3 Changed 7 years ago by Owen Arnold

refs #7400. Change what is thrown.

Changeset: 3ad094ff10d322903a8d506b9f87cb4d015533e4

comment:4 Changed 7 years ago by Owen Arnold

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:5 Changed 7 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:6 Changed 7 years ago by Martyn Gigg

I think the point of this ticket has been missed. #7325 mentions that the last line of the message is confusing: 

PeaksInRegion-[Error] PeaksInRegion: Attempt to dereference zero pointer (Detector) in function Peak
PeaksInRegion-[Error] Error in execution of algorithm PeaksInRegion:
PeaksInRegion-[Error] PeaksInRegion: error (see log)

While the error message has been improved generally the last line is still misleading. However, this line doesn't come from PeaksInRegion it is actually a general message thrown from MultiThreaded.h when an exception has been caught in a parallel loop.

I think the issue of error reporting from these situations needs to be addressed differently and have created #7446 to do this.

The error message itself is improved so I'll pass this ticket.

comment:7 Changed 7 years ago by Martyn Gigg

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/7400_remove_message'

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8246

Note: See TracTickets for help on using tickets.