Ticket #7403 (closed: fixed)
supported.facilities property looks unnecessary
Reported by: | Roman Tolchenov | Owned by: | Nick Draper |
---|---|---|---|
Priority: | major | Milestone: | Release 2.6 |
Component: | Framework | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Martyn Gigg |
Description
If a facility isn't added to that property it cannot be seen by Mantid (at least by some parts of it eg StartLiveListener GUI) although it is defined in Facilities.xml
Change History
comment:1 Changed 7 years ago by Nick Draper
- Status changed from new to accepted
- Owner set to Nick Draper
comment:2 Changed 7 years ago by Nick Draper
Previous entry: Stored here for historical purposes
# A semi-colon separated list of supported facilities supported.facilities = ISIS;SNS;HFIR;NCNR;LENS;ILL;SINQ;LLB
comment:3 Changed 7 years ago by Nick Draper
Specific areas that might be affected:
- FirstTimeSetup
- ConfigDialog
- MultiFileNameParser
Despite the description this should not have any effect on StartLiveListener, that always worked on the currently set default facility - you just couldn't change the default facility in the gui due to this issue.
comment:4 Changed 7 years ago by Nick Draper
- Status changed from accepted to verify
- Resolution set to fixed
To test: check that the facility name drop down lists still work in
- help->First time setup
- View->Preferences -> Mantid
Check the unit test still work
Check that file name searching still works when specifying files by
- Run number only for the default intrument eg 1234
- Inst short name and run number HET1234
- Inst name and run number for a different facility than that set as default eg CNCS7860 when default facility set to ISIS
comment:5 Changed 7 years ago by Nick Draper
re #7403 Just a start by changing the .properties file
Changeset: abe4fc38a049aa78542ff99d9ef4bf46e29d1d13
comment:6 Changed 7 years ago by Nick Draper
re #7403 adding list methods to config service
Changeset: 80148f64a8b6a78397e73aac1f8d878726335349
comment:7 Changed 7 years ago by Nick Draper
re #7403 changed all usages
Changeset: 0872787f9a1831af0638e96709747264ab81d0c1
comment:8 Changed 7 years ago by Martyn Gigg
- Status changed from verify to reopened
- Resolution fixed deleted
Some new work will need the functions to be exposed to Python.
comment:9 Changed 7 years ago by Nick Draper
re #7403 expose new methods to python and add test
Changeset: 4d1224e8f1265cb8ec3f79309cba6ebbf470a98d
comment:11 Changed 7 years ago by Nick Draper
- Status changed from accepted to verify
- Resolution set to fixed
comment:12 Changed 7 years ago by Martyn Gigg
- Status changed from verify to verifying
- Tester set to Martyn Gigg
comment:14 Changed 7 years ago by Russell Taylor
I think it's the changes here that have led to 'TEST' being one of the available facilities in the First-time setup and Preferences dialogs. #7487 has been created for fixing that.
comment:15 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8249