Ticket #7417 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Workspace menu -> Rename no longer works

Reported by: Russell Taylor Owned by: Russell Taylor
Priority: major Milestone: Release 2.6
Component: GUI Keywords:
Cc: Blocked By:
Blocking: Tester: Wenduo Zhou

Description (last modified by Russell Taylor) (diff)

A couple of issues here:

  • Work under #6983 broke the 'Rename' option under the Workspace menu. When you first select the menu you now get the message Object::connect: No such slot MantidUI::renameWorkspace() because the method's argument type was changed and lost it's default in the process. Selecting 'Rename' thus does nothing.
    • In the same work a bug was introduced at MantidPlotUI.cpp line 1508, where an assignment is made to the first element of an empty list. append should be used instead.
  • This bug was already present: If you rename the workspace in this way, the matrix remains but still refers to the old name, so you can no longer for example plot a spectrum (the error is "Workspace .... not found").

Change History

comment:1 Changed 7 years ago by Russell Taylor

  • Status changed from new to accepted

comment:2 Changed 7 years ago by Russell Taylor

  • Description modified (diff)

comment:3 Changed 7 years ago by Russell Taylor

Re #7417. Fix Workspace->Rename menu item.

Changeset: a2dc322e4395b7339a33b8046f9077f76be6d94a

comment:4 Changed 7 years ago by Russell Taylor

Re #7417. Update workspace name when renamed

Ensure that the workspace name held internally by (and displayed in the title bar of) the MantidMatrix object is updated if the workspace is renamed.

Changeset: dd6c2c458adc505fe48a2a23347f3f4c9f3f8885

comment:5 Changed 7 years ago by Russell Taylor

Re #7417. Address cppcheck warnings.

…while I'm touching the file anyway.

Changeset: 341418bf9b9bd400ea24d8ecc11eda861e4a536f

comment:6 Changed 7 years ago by Russell Taylor

  • Status changed from accepted to verify
  • Resolution set to fixed

Tester: Branch is feature/7417_rename_broken

Test by loading a workspace and bringing up the data matrix by double clicking on the workspace name. Then go to the menu bar and choose Workspace->Rename and run the rename algorithm. Previously a warning would appear on the console when the menu was first selected and clicking Rename would do nothing at all.

Check that you can still plot a spectrum or 'Show Detectors', etc., via right-click on the matrix. Check that you can rename again from the same menu.

comment:7 Changed 7 years ago by Wenduo Zhou

  • Status changed from verify to verifying
  • Tester set to Wenduo Zhou

comment:8 Changed 7 years ago by Russell Taylor

Re #7417. Fix Workspace->Rename menu item.

Changeset: 21ec580b0fb100fcfddc6ec0cac74c13bd8af75e

comment:9 Changed 7 years ago by Russell Taylor

Re #7417. Update workspace name when renamed

Ensure that the workspace name held internally by (and displayed in the title bar of) the MantidMatrix object is updated if the workspace is renamed.

Changeset: 50a4f179269791b9c7f3eeb265ae01fb37cd3428

comment:10 Changed 7 years ago by Russell Taylor

Re #7417. Address cppcheck warnings.

…while I'm touching the file anyway.

Changeset: ddb005da6692172954bfc83da103b9ca94797feb

comment:11 Changed 7 years ago by Wenduo Zhou

  • Status changed from verifying to closed

The reported bug does not appear. All tests related to renaming workspace are passed. And thus the ticket is closed.

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8263

Note: See TracTickets for help on using tickets.