Use of IDF outline causes crash

[Anders Markvardsen]

Hi Roman,

Rob Dalgliesh has be using the outline feature.

Observation is:

1. Run LoadEmptyInstrument on attached LARMOR_Definition.xml. This IDF loads.

2. Do show instrument and Mantid crashes

Here Rob uses

<type name="LARMORSANSDetector" outline="yes"> <component type="LARMORUptube">

where type="LARMORUptube" is refering to an assembly of pixels.

Here either inform the user that outline can only be used to outline pixels (i.e. leafs) and not assembly of pixels. Or, make the effect such that this XML makes each of the types "LARMORUptube" outlined (equivalent to set <type name="LARMORUptube" outline="yes">)

[Anders Markvardsen]

Note I have just update the doc for outline on www.mantidproject.org/IDF a bit to

If you find working with the instrument in MantidPlot's instrument 3D view too slow then using the 'outline' attribute can speed performance up. For example if a component is a cylindrical tube where slices of this tube are treated as detector pixels then this can be done by adding 'outline' attribute to the <type> tag and setting its value to "yes".

<div style="border:1pt dashed black; background:#f9f9f9;padding: 1em 0;"> <source lang="xml">

<type name="standard-tube" outline="yes">

<component type="standard-pixel" >

<location y="-1.4635693359375"/> <location y="-1.4607080078125"/> <location y="-1.4578466796875"/>

</component>

</type>

</source></div> The 'outline attribute' only affects the 3D view of the instrument. Note, using outline will give the impression in 3D view (not in any of the projection view views, i.e. 2D views) that pixels along a tube are equeally spaces regardless of whether this is true. Hence, for example, the effect of a tube calibration will not show up in the 3D view if outline is used, although it will show up in any of the 2D views of the instrument.

As part of this ticket check that this doc matches what is done in the code

[Roman Tolchenov]

Throw exception when IDF "outline" is used with wrong types. Re #7422

Changeset: 990b687a1ecd0cff596489f3dd28eb9ad37e1810

[Roman Tolchenov]

To tester:

Use the original definition file to see that there is no crash.

Use the corrected definition file to see that outline option works for this instrument.

[Owen Arnold]

Seems to behave as expected now.

[Owen Arnold]

Merge remote-tracking branch 'origin/bugfix/7422_idf_outline_crash'

[Stuart Campbell]

This ticket has been transferred to github issue ​8268