Ticket #7424 (closed: fixed)
Clear compiler warnings on OS X
| Reported by: | Russell Taylor | Owned by: | Russell Taylor |
|---|---|---|---|
| Priority: | minor | Milestone: | Release 2.6 |
| Component: | Framework | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Mathieu Doucet |
Description
A number of Intel compiler warnings have been allowed into the master branch.
Change History
comment:2 Changed 7 years ago by Russell Taylor
Re #7424. A better way of setting variable to infinity.
Changeset: 5fd9caac79e6f05aa48d3e848a81ed84760970bd
comment:3 Changed 7 years ago by Russell Taylor
Re #7424. Remove integer conversion compiler warning.
Changeset: b9814165c14fddea0f355209185bc007a63680d5
comment:4 Changed 7 years ago by Russell Taylor
Re #7424. Remove now unused variable.
Changeset: 87ce15d9ff21824e6a86f46723d126419fc76fa9
comment:5 Changed 7 years ago by Russell Taylor
Re #7424. Remove no-longer needed warning suppression.
Changeset: efea9f50c0e55c0917e496413d53781edb1f2044
comment:6 Changed 7 years ago by Russell Taylor
Re #7424. Address cppcheck warnings.
…while I'm touching the file anyway.
Changeset: 28694874dcff39b97faf30ddb35ab69116cda821
comment:7 Changed 7 years ago by Russell Taylor
Re #7424. Put 32 bit member variables next to each other.
This saves 8 bytes per object padding with gcc (which seems to ignore the packing pragma) and will allow me to turn off the packing for the intel compiler (which gives an avalanche of warnings) without any effect.
Changeset: 74f908dc7c2fc27a5ed1fb771d552a0c46e0f0c1
comment:8 Changed 7 years ago by Russell Taylor
Re #7424. Turn of packing for the Intel compiler.
With the present set of member variables it makes no difference and, for the most recent compiler version, leads to a warning every time the header is included (which is a lot!). N.B. The packing also has no effect with gcc but I've left it on there.
Changeset: 21e177fac08f1ef7ef53a853975e2cfc6803c7bc
comment:9 Changed 7 years ago by Russell Taylor
Re #7424. Tidy-ups. No functional changes.
Changeset: d9058e7bcb671fbcc45a65d225070b978e93df40
comment:10 Changed 7 years ago by Russell Taylor
Re #7424. Turn off packing for the Intel compiler.
With the present set of member variables it makes no difference and, for the most recent compiler version, leads to a warning every time the header is included (which is a lot!). N.B. The packing also has no effect with gcc but I've left it on there.
Changeset: 3691bcf3cd3849577789eeb516acff1a56e43ce9
comment:11 Changed 7 years ago by Russell Taylor
Re #7424. Turn off packing for the Intel compiler.
It makes no difference and gives a warning. (N.B. there's no difference with gcc either, only visual c++.)
Changeset: f38dc81c6d8d0c9f9e0cc8720ea23cddddc016ee
comment:12 Changed 7 years ago by Russell Taylor
Re #7424. Tidy-ups. No functional changes.
Changeset: 37840d5c442340650e5752bff195159b7079f8d3
comment:13 Changed 7 years ago by Russell Taylor
- Status changed from accepted to verify
- Resolution set to fixed
There should be no more compiler warnings in the clean OS X builds of the develop branch.
comment:14 Changed 7 years ago by Mathieu Doucet
- Status changed from verify to verifying
- Tester set to Mathieu Doucet
comment:15 Changed 7 years ago by Mathieu Doucet
- Status changed from verifying to closed
No more warnings. Mantidplot is behaving normally.
comment:16 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8270
