Ticket #7426 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Enable LoadGSS and SaveGSS to use spectrum number as bank ID

Reported by: Wenduo Zhou Owned by: Wenduo Zhou
Priority: critical Milestone: Release 2.6
Component: Diffraction Keywords:
Cc: petersonpf@… Blocked By:
Blocking: Tester: Karl Palmen

Description

Add an option to LoadGSS and SaveGSs such that a spectrum's spectrum number is used as bank ID in the GSAS data file.

Change History

comment:1 Changed 7 years ago by Wenduo Zhou

  • Status changed from new to accepted

comment:2 Changed 7 years ago by Wenduo Zhou

Implemented for LoadGSS. Refs #7426.

Changeset: a8ff19dab9d7293f0c07c56530f7a25cce3b404e

comment:3 Changed 7 years ago by Wenduo Zhou

Implemented to SaveGSS. Refs #7426.

Changeset: c16edb4a8442d5d3e206182820e5590050bc558e

comment:4 Changed 7 years ago by Wenduo Zhou

Resolved conflict. Refs #7426.

Changeset: b0e4328e69b939c259dce77a19bd5dbb1e80c4e6

comment:5 Changed 7 years ago by Wenduo Zhou

Added a new file for test. Refs #7426.

Changeset: e01ff9e74a6347c83a51bbb46d749d1567f5aebf

comment:6 Changed 7 years ago by Wenduo Zhou

  • Status changed from accepted to verify
  • Resolution set to fixed

Instruction to verify

  1. Locate gsas data file gss1.txt in mantid/Test/AutoTestData/
  2. Be noted that there are 3 banks in gss1.txt. They are 1, 3 and 5 respectively;
  3. Run LoadGSS on gss1.txt by setting 'UseBankIDasSpectrumNumber' to true;
  4. Check the generated workspace such that the 3 spectra have spectrum number as 1, 3 and 5. An easy way to find out this is to plot the workspace;
  5. Run SaveGSS on the workspace by setting 'UseSpectrumNumberAsBankID' to true.
  6. Compare the newly generated GSAS file with gss1.txt

comment:7 Changed 7 years ago by Karl Palmen

  • Status changed from verify to verifying
  • Tester set to Karl Palmen

comment:8 Changed 7 years ago by Karl Palmen

  • Status changed from verifying to verify

Merge remote-tracking branch 'origin/feature/7426_gss_specid'

comment:9 Changed 7 years ago by Karl Palmen

  • Status changed from verify to verifying

comment:10 Changed 7 years ago by Karl Palmen

  • Status changed from verifying to closed

comment:11 Changed 7 years ago by Nick Draper

  • Component changed from Framework to Diffraction

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8272

Note: See TracTickets for help on using tickets.