Ticket #7430 (closed: fixed)
Fix vtkSplatterPlotFactory behavior
| Reported by: | Michael Reuter | Owned by: | Michael Reuter |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.0 |
| Component: | GUI | Keywords: | Maintenance |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Peter Peterson |
Description
The vtkSplatterPlotFactory throws exceptions in the vtkSplatterPlot::RequestData call and this gets the system in a very bad state. The exceptions should be thrown in vtkSplatterPlot::RequestInformation like the other plugins and their helpers do.
Change History
comment:2 Changed 7 years ago by Nick Draper
- Milestone changed from Release 2.6 to Backlog
Moved to backlog at the code freeze for R2.6
comment:3 Changed 7 years ago by Michael Reuter
- Status changed from new to inprogress
- Keywords Maintenance added
- Milestone changed from Backlog to Release 3.0
comment:4 Changed 7 years ago by Michael Reuter
Specifically, the create call should not call the validate method and the extra dimension check. These should be moved to initialize function.
comment:5 Changed 7 years ago by Michael Reuter
Refs #7430. Fixing factory behavior.
This involved moving the validation steps into the initialize call and fixing the unit tests. The change allows the execute call to be used without a valid workspace, but this will be dealt with in another ticket. Also, went through and did a lot of code formatting.
Changeset: cf44bdbc0b2ec0549f268dad9916c57007ab3f96
comment:6 Changed 7 years ago by Michael Reuter
- Status changed from inprogress to verify
- Resolution set to fixed
The branch is here.
To test: Load up your favorite 3D MDEventWorkspace in the VSI and check out the SplatterPlot view. No outward behavior changed, so things should work as before.
