Ticket #7443 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Save dialog doesn't append correct extension when all files is selected

Reported by: Samuel Jackson Owned by: Samuel Jackson
Priority: major Milestone: Release 2.6
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Mathieu Doucet

Description (last modified by Nick Draper) (diff)

Noticed in the SaveSPE algorithm on both Windows and Ubuntu. When entering a file name to save the SPE file a filter is not automatically appended if not specified. Instead the dialog just appends "All Files(*)" to the file name.

Reproduced using the following steps:

1) Load MARIReduction.nxs in the systemtests/analysistests folder.

2) Select algorithm SaveSPE

3) Browse to select a directory to save it in

4) Type a name for the file, but don't supply an extension.

5) Saving this will cause "All Files(*)" to be appended to the file name.

Change History

comment:1 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned
  • Owner set to Samuel Jackson
  • Description modified (diff)

comment:2 Changed 7 years ago by Samuel Jackson

  • Status changed from assigned to accepted

comment:3 Changed 7 years ago by Samuel Jackson

Changing SaveSPE to have the default file extension ".spe"

Refs #7443

Changeset: 232e8700b56dc1fe090c0aa02fd9ecb01a04ccfe

comment:4 Changed 7 years ago by Samuel Jackson

File dialog now defaults to empty string as extension

if no extension filters were specified.

Refs #7443

Changeset: 8cefe0e18eafd68b117de74bf189c248e5372373

comment:5 Changed 7 years ago by Samuel Jackson

  • Status changed from accepted to verify
  • Resolution set to fixed

To test:

1) Open Mantid and load a file suitable for use with the SaveSPE algorithm (I used MARIReduction in SystemTests > AnalysisTests > ReferenceResults)

2) Choose the SaveSPE algorithm and browse for a save location.

3) Type a name for the file, but don't specify an file extension.

4) Algorithm should default to "filename.spe" when you choose a location

5) Test with some different loading algorithms. Especially one which doesn't specify any file extensions to check that no extension is appended if there is no default specified.

comment:6 Changed 7 years ago by Mathieu Doucet

  • Status changed from verify to verifying
  • Tester set to Mathieu Doucet

comment:7 Changed 7 years ago by Mathieu Doucet

  • Status changed from verifying to closed

I checked that I could reproduce the problem, then confirmed that the fix produces the correct name.

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 8289

Note: See TracTickets for help on using tickets.