Ticket #7451 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Parallel DgsReduction on Fermi

Reported by: Andrei Savici Owned by: Andrei Savici
Priority: critical Milestone: Release 2.6
Component: Direct Inelastic Keywords:
Cc: Blocked By:
Blocking: Tester: Mathieu Doucet

Description

Enable parallel DgsReduction

Change History

comment:1 Changed 7 years ago by Andrei Savici

  • Status changed from new to accepted

comment:2 Changed 7 years ago by Andrei Savici

Refs #7451. DGSReduction parallel button in GUI

Changeset: 835f33aa1e7984db7e119c20f35e6284cd059a3f

comment:3 Changed 7 years ago by Andrei Savici

Refs #7451. Merge branch 'feature/7451_ParallelDGS' into develop

Conflicts:

Code/Mantid/scripts/Interface/reduction_gui/reduction/inelastic/dgs_reduction_script.py

Changeset: 8700126e725e07482997ee765bf6e6da20d6a51c

comment:4 Changed 7 years ago by Andrei Savici

Refs #7451. DGSReduction parallel button in GUI

Changeset: 8c1e094573c8863807c063a18488d7d392188685

comment:5 Changed 7 years ago by Andrei Savici

Allow multiple file load in DGSReduction gui. Refs #7451

Changeset: 15c993577c5265f936351b56e2849bddedbd3c4c

comment:6 Changed 7 years ago by Andrei Savici

Expose correct method to python. Refs #7451

Updated FlatBackground call to CalculateFlatBackground. Needs to be tested for events mode.

Changeset: e98275f4dc01250cdaa8fb4b44d63692902d701b

comment:7 Changed 7 years ago by Andrei Savici

Small changes to DgsReduction to allow multiple files. Refs #7451

Changeset: 6aa3037d853d40a6ef2dea5c1c3132b00e1856fa

comment:8 Changed 7 years ago by Andrei Savici

Additions to ui. Refs #7451

Changeset: a6e945c2f24c9c71808a839a5aac2c9a97addb6e

comment:9 Changed 7 years ago by Nick Draper

  • Status changed from accepted to assigned

comment:10 Changed 7 years ago by Nick Draper

  • Status changed from assigned to new

comment:11 Changed 7 years ago by Andrei Savici

Updates to DGS gui. Refs #7451

Changeset: 322bf676757c356e4b089bb548a6546e4a432597

comment:12 Changed 7 years ago by Andrei Savici

  • Status changed from new to inprogress

comment:13 Changed 7 years ago by Andrei Savici

Re #7451. Merge branch 'feature/7451_ParallelDGS' into develop

Conflicts:

Code/Mantid/scripts/Interface/reduction_gui/reduction/inelastic/dgs_reduction_script.py

Changeset: b757a1059f64c0ba6dd85dbd0757045921a86123

comment:14 Changed 7 years ago by Andrei Savici

  • Status changed from inprogress to verify
  • Resolution set to fixed

This ticket should be tested by someone at SNS. Make sure you enable cluster.submission=on in your mantid profile, and test it on analysis.sns.gov (that's the only one that can submit jobs to Fermi)

  1. Check if reduction is still working. Check if you can save/load the status. Check if the exported script contains the SaveNexus command
  2. At some point there were some conflicts with develop. Check if you can change the instrument
  3. Check if time independent background works, and does not complain about deprecated FlatBackground algorithm. If you can, check with flat background in event mode
  4. Check if you can load multiple files with the syntax of Load
  5. Check if parallel submission works. Check for multiple files, including adding some of them together. Look at the submitted script, see if the number of files to load makes sense. Check if the answer is in the correct folder

comment:15 Changed 7 years ago by Mathieu Doucet

  • Status changed from verify to verifying
  • Tester set to Mathieu Doucet

comment:16 Changed 7 years ago by Andrei Savici

Fix batch for adding files. Refs #7451

Changeset: b2dd017b159957bc09683e881f882b26065f5a34

comment:17 Changed 7 years ago by Mathieu Doucet

  • Status changed from verifying to closed

Works as advertised. There will be more work needed when we start allowing jobs sent from nodes that don't have the SNS mount. I created a new ticket for that work: #7493

comment:18 Changed 7 years ago by Nick Draper

  • Component changed from User Interface to Direct Inelastic

comment:19 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 8297

Note: See TracTickets for help on using tickets.