Ticket #7454 (closed: fixed)
Unit test failures in Debug mode on windows
Reported by: | Alex Buts | Owned by: | Alex Buts |
---|---|---|---|
Priority: | major | Milestone: | Release 2.6 |
Component: | Framework | Keywords: | |
Cc: | martyn.gigg@… | Blocked By: | |
Blocking: | Tester: | Martyn Gigg |
Description (last modified by Alex Buts) (diff)
There are number of crashes happens when one tries to run algorithms tests in debug mode under windows. The crashes caused by numerous small bugs/coder uncertainties and are seems easy to fix, but point to some bugs not identified on other OS.
This ticket is to fix these uncertainties/bugs and to fix unit tests for algorithms in debug mode on windows.
Change History
comment:2 Changed 7 years ago by Alex Buts
refs #7454 Merging conflicts.
Merge branch 'feature/7454_little_WinBugs' into develop
Conflicts:
Code/Mantid/Framework/Geometry/src/Instrument.cpp
Changeset: f29de34c67911a10c5dc94c68250a5bffb2484e8
comment:4 Changed 7 years ago by Alex Buts
- Status changed from accepted to verify
- Resolution set to fixed
comment:5 Changed 7 years ago by Martyn Gigg
- Status changed from verify to verifying
- Tester set to Martyn Gigg
comment:6 Changed 7 years ago by Martyn Gigg
- Summary changed from Unut test failiers for Algorithms in Debug mode on windows. to Unit test failures in Debug mode on windows
comment:7 Changed 7 years ago by Martyn Gigg
- Status changed from verifying to reopened
- Resolution fixed deleted
The changes look sensible, however there are some style points that need addressing.
- Why was the indentation level in PDFFourierTransform changed? It was correct according to the coding standards before and now is not. You may want to check your tab/space settings. A tab should be set to 2 spaces.
- Why was the if statement in ParameterMap.cpp:543 split up? It could have just been flipped to:
if( it_found != m_map.end() && it_found->first ) {
- If the two if statements need to be kept, the first should have braces around it.
Once these problems are fixed then it will be fine.
comment:8 Changed 7 years ago by Alex Buts
1) Studio have automatically untabyfied these lines as spaces and tabs were mixed there. Will do autoformatiing of this class which will probably bring on range of formal changes.
2) Coupled statement has the problem -- Probably the compiler is broken. I've analysed previous code changes and see that it has been changed from suggested order to the current order earlier on. It is probably better to leave it as it is as it is most safe option.
comment:10 Changed 7 years ago by Martyn Gigg
If you want to keep the split if statement you are missing some braces after the first if statement. That needs to be fixed
comment:11 Changed 7 years ago by Alex Buts
refs #7454 Formatted PDFFourierTransform according to standard
Changeset: a51c6723c490639f357c26c9869302a03853d7b6
comment:12 Changed 7 years ago by Alex Buts
refs #7454 Added couple of brackets to ParameterMap
Changeset: e778973a812a398b9f6ee677adfc9c1cc34e4fa1
comment:13 Changed 7 years ago by Alex Buts
refs #7454 Reformatted PDFFourierTransform again
Changeset: 6f2b90ee2312673774eb4592371453da47655197
comment:14 Changed 7 years ago by Alex Buts
- Status changed from accepted to verify
- Resolution set to fixed
- Description modified (diff)
comment:16 Changed 7 years ago by Martyn Gigg
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/7454_little_WinBugs'
comment:17 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8300
Three commits to this ticket have been cherry-picked from #7351 namely:
http://trac.mantidproject.org/mantid/changeset/b3c51923444cab1ef5eae67ee196c2c144ba21c5/
http://trac.mantidproject.org/mantid/changeset/8e1094ceed3700800b6bb748fb7bfa47a26c35b9/
http://trac.mantidproject.org/mantid/changeset/5c93875e2d1ae9143b7c2b46a6e725150dfc07cc/
To tester check by:
1) Code review. 2) All unit tests pass 3) Unit tests for algorithms in debug mode under windows pass.