Ticket #7468 (closed: fixed)
Some C++ interface code is still using the old api
Reported by: | Martyn Gigg | Owned by: | Martyn Gigg |
---|---|---|---|
Priority: | blocker | Milestone: | Release 2.6 |
Component: | GUI | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Mathieu Doucet |
Description
It needs to be ported to the new to keep working.
Change History
comment:2 Changed 7 years ago by Martyn Gigg
Port UserSubWindow to use PythonRunner object. Refs #7468
Isolates the code that does the python execution and output capture.
Changeset: 651e0e3844f422d48151c0be6d3f1d4829bd70f5
comment:3 Changed 7 years ago by Martyn Gigg
Add logging to PythonRunner for easier debugging of interface code.
Refs #7468
Changeset: 7052b1153ec81b0b6eb4150fe68d267b14ee512d
comment:4 Changed 7 years ago by Martyn Gigg
Move ConvertToEnergy python code to new API.
Includes Indirect.cpp helper class. Refs #7468
Changeset: 693c41fc96d342e600f8e19839190157f7856542
comment:5 Changed 7 years ago by Martyn Gigg
Fix spectra plotting option on Indirect SofQW GUI. Refs #7468
Changeset: ae5946b7a225b07e5a481353b9ffaa767d963e35
comment:6 Changed 7 years ago by Martyn Gigg
Move IDA code to use new python API.
Includes IndirectDataAnalysis.cpp & CalcCorr helper. Refs #7468
Changeset: 6d88534ac707692b200320912a7b20ffcaf7a76e
comment:7 Changed 7 years ago by Martyn Gigg
Port CreateMDWorkspace GUI to new Python API. Refs #7468
Changeset: 418dd11ccc7fbd4b572ba4db7535b8a66a9e979e
comment:8 Changed 7 years ago by Martyn Gigg
Port reset of IndirectDiffractionReduction to new API.
Refs #7468
Changeset: fee3d2aa135a8476f9a4c289b5da38e0148de65f
comment:9 Changed 7 years ago by Martyn Gigg
Port MDWDiag to new Python API. Refs #7468
Changeset: 961cf2589a6a8371b6ae2fd6adc0b916a9a81906
comment:10 Changed 7 years ago by Martyn Gigg
Remove mantidsimple reference in comment. Refs #7468
Changeset: 42eb78f732176e648333f6d3195600eb58e3e53b
comment:11 Changed 7 years ago by Martyn Gigg
Remove old API usage from SliceViewer tests. Refs #7468
Changeset: bec1de3f72b4c2ccebe0d836946599a96268f80d
comment:12 Changed 7 years ago by Martyn Gigg
- Status changed from inprogress to verify
- Resolution set to fixed
Branch: feature/7468_clearup_old_api_interfaces
Tester: Firstly all of the tests should be passing. The changes here affected the following interfaces from the menu:
- CreateMDWorkspace - No wiki
- ConvertToEnergy - http://www.mantidproject.org/Indirect:ConvertToEnergy
- Indirect Data Analysis - http://www.mantidproject.org/Indirect:Indirect_Data_Analysis
- Indirect Diffraction - http://www.mantidproject.org/Indirect_Diffraction_Reduction
The links provide instructions on how to run them. Please check that they all still work.
comment:13 Changed 7 years ago by Mathieu Doucet
- Status changed from verify to verifying
- Tester set to Mathieu Doucet
comment:14 Changed 7 years ago by Mathieu Doucet
- Status changed from verifying to closed
I tested out the UIs and the CreateMDWorkspace algorithm. I also looked quickly through the code changes. Everything looks good.
comment:15 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8313