Ticket #7472 (closed: fixed)
Get Quick Auxilary Functions Under Test
| Reported by: | Owen Arnold | Owned by: | Owen Arnold |
|---|---|---|---|
| Priority: | major | Milestone: | Release 2.6 |
| Component: | Reflectometry | Keywords: | |
| Cc: | Blocked By: | #7372 | |
| Blocking: | #7317 | Tester: | Nick Draper |
Description
Quick is a big and complex script. I'm splitting up the umbrella ticket #7317, by getting the auxilary functions under test first. These are helper functions, that do little in terms of the Reflectometry workflow themselves. They are:
- coAdd
- getGroup
- cleanup
It should be possible to provide a high degree of test coverage of these functions via the python unit tests. whereas the scientific functions are likely to be too complex to do anything other than system test.
Once I've done this, it should become a lot easier to safely tackle the parts of the script that apply the scientific parts of the reduction.
Change History
comment:4 Changed 7 years ago by Owen Arnold
refs #7472. New unit test script.
Covering cleanup and starting work on coAdd.
Changeset: b4b3b5104b9d31cf466acdbd5e0565d308c42ef2
comment:5 Changed 7 years ago by Owen Arnold
refs #7472. Adding tests for getGroup.
Lots of options for using getGroup. Cover the specific 'whattoget' arguments.
Changeset: 069604c7f762484774759a1842346e89296290b5
comment:6 Changed 7 years ago by Owen Arnold
refs #7472. Check log error codes.
Changeset: c72ee7b2f23bb8f578e379aaab32b95aee99cff7
comment:7 Changed 7 years ago by Owen Arnold
refs #7472. Make tests run quicker
Avoid cyclic loading/deleting of workspaces via the constructor/destructor. Tests now run in 1/4 the time.
Changeset: 516cb690735363a1146833eed5885f113dc8c1a7
comment:8 Changed 7 years ago by Owen Arnold
refs #7472. Fix merge conflict.
Changeset: bdf92fc1c03a35eadb361fb6225b445cb9f4aa78
comment:9 Changed 7 years ago by Owen Arnold
- Status changed from assigned to verify
- Resolution set to fixed
Tester: You should see these 8 new tests running and passing on the develop incremental branch. Other than that you may wish to code-review the unit tests.
Note that the point of this ticket is to test the existing functionality, so that we know what it does, and can safely modify it. I know that there is much work needed to improve this quick script.
comment:10 Changed 7 years ago by Martyn Gigg
- Status changed from verify to verifying
- Tester set to Martyn Gigg
comment:11 Changed 7 years ago by Martyn Gigg
- Status changed from verifying to reopened
- Resolution fixed deleted
The test file imports the old API at the top, which needs to be removed.
comment:12 Changed 7 years ago by Owen Arnold
refs #7472. Remove old API imports.
Changeset: e3ca1c53b8afa1ce5f2a0b133b585256daa2f39f
comment:13 Changed 7 years ago by Owen Arnold
- Status changed from reopened to verify
- Resolution set to fixed
comment:14 Changed 7 years ago by Nick Draper
- Status changed from verify to verifying
- Tester changed from Martyn Gigg to Nick Draper
comment:15 Changed 7 years ago by Nick Draper
- Status changed from verifying to verify
Merge remote-tracking branch 'origin/feature/7472_test_auxilary'
comment:16 Changed 7 years ago by Nick Draper
code review good, tests pass
comment:19 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8317
