Ticket #7482 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Allow GroupWorkspaces to make a group containing only a single member

Reported by: Martyn Gigg Owned by: Martyn Gigg
Priority: major Milestone: Release 2.6
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Gesner Passos

Description

This allows scripts to process a variable size list of items and just group all of them without special handling for the single item case.

Change History

comment:1 Changed 7 years ago by Russell Taylor

Last edited 7 years ago by Russell Taylor (previous) (diff)

comment:2 Changed 7 years ago by Martyn Gigg

Indentation changes only before real work. Refs #7482

Changeset: a8d276fceb4eed3c23560c248b534b6358fb7c69

comment:3 Changed 7 years ago by Martyn Gigg

Remove restriction on minimum of 2 workspaces for GroupWorkspaces.

Refs #7482

Changeset: cad791a4930eb272256b8121823155f4f0f41260

comment:4 Changed 7 years ago by Martyn Gigg

Refactor GroupWorkspaces to improve structure.

Refs #7482

Changeset: 2cc9209f9075aea6762585ed6ead980da1052b4e

comment:5 Changed 7 years ago by Martyn Gigg

Indentation changes only before real work. Refs #7482

Changeset: a8d276fceb4eed3c23560c248b534b6358fb7c69

comment:6 Changed 7 years ago by Martyn Gigg

Remove restriction on minimum of 2 workspaces for GroupWorkspaces.

Refs #7482

Changeset: cad791a4930eb272256b8121823155f4f0f41260

comment:7 Changed 7 years ago by Martyn Gigg

Refactor GroupWorkspaces to improve structure.

Refs #7482

Changeset: 2cc9209f9075aea6762585ed6ead980da1052b4e

comment:8 Changed 7 years ago by Martyn Gigg

Removed file usage from GroupWorkspacesTest.

It just uses the helpers now. Refs #7482

Changeset: cbd99251a42edcc59311b2330753d50cb9ce19ce

comment:9 Changed 7 years ago by Martyn Gigg

Formatting changes only to UnGroupWorkspacesTest before real work.

Refs #7482

Changeset: 7ea1ea75a2abbe696ceb41a7919d8340c3a19fca

comment:10 Changed 7 years ago by Martyn Gigg

Removed file usage from UnGroupWorkspacesTest. Refs #7482

Changeset: 9344adc03a30f13febf5dec707f8c9b65b636d8c

comment:11 Changed 7 years ago by Martyn Gigg

Update Python SimpleAPITest to account for GroupWorkspaces changes.

Refs #7482

Changeset: 9ba19d741193f13dade7351fb1b63d69c07e468c

comment:12 Changed 7 years ago by Martyn Gigg

  • Status changed from new to verify
  • Resolution set to fixed

Branch: feature/7482_allow_groupworkspaces_a_single_item

Tester: The aim here was to simply remove the restriction that the GroupWorkspaces algorithm required two workspaces to group. This only affects the algorithm. The GUI will still only enable the grouping option if two or more workspaces are selected.

Main things to check:

  • Use the Group button in MantidPlot to group various numbers of workspaces and check it works;
  • Check that you can only mix TableWorkspaces with other types and that for example you can't have a group with an EventWorkspace & Workspace2D in
  • Check all this through running the algorithm manually too.

While removing the restriction I took the opportunity to improve the Group/UnGroupWorkspacesTest so that they no longer use files and just create their test workspaces in memory.

comment:13 Changed 7 years ago by Gesner Passos

  • Status changed from verify to verifying
  • Tester set to Gesner Passos

comment:14 Changed 7 years ago by Gesner Passos

  • Status changed from verifying to reopened
  • Resolution fixed deleted

Check that you can only mix TableWorkspaces with other types and that for example you can't have a group with an EventWorkspace & Workspace2D in

I found that there was no this restriction before. I showed Martyn, and he wants to reanalyze the requirements for this ticket.

comment:15 Changed 7 years ago by Martyn Gigg

  • Status changed from reopened to inprogress

comment:16 Changed 7 years ago by Martyn Gigg

Remove restriction of mixing workspace types in GroupWorkspaces

The old code made it look like this was a restriction but it was not implemented correctly so you could group whatever you like. It really makes no sense anyway so simply remove the restriction. Refs #7469

Changeset: 3cd00e964b254149e5a8573edc93e6e61c117baa

comment:17 Changed 7 years ago by Martyn Gigg

  • Status changed from inprogress to verify
  • Resolution set to fixed

After looking at the old code, it seems that it would allow a group of 2 members to be what ever type due to a bug in the old code but not anything more. Given that this behaviour seems overly restrictive anyway the type checking has simply been removed. The test instructions are now as follows.

Branch: feature/7482_allow_groupworkspaces_a_single_item

Tester: The aim here was to simply remove the restriction that the GroupWorkspaces algorithm required two workspaces to group. This only affects the algorithm. The GUI will still only enable the grouping option if two or more workspaces are selected.

Main things to check:

  • Use the Group button in MantidPlot to group various numbers of workspaces and check it works;
  • Check that you can mix any types of workspace you like
  • Check all this through running the algorithm manually too.

comment:18 Changed 7 years ago by Gesner Passos

  • Status changed from verify to verifying

comment:19 Changed 7 years ago by Gesner Passos

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/7482_allow_groupworkspaces_a_single_item'

comment:20 Changed 7 years ago by Gesner Passos

I have loaded almost all the files available in LoadLotsOfFiles and them grouped them randomly. I was able to group small groups, single workspaces, and many workspaces, and ungroup them as well. The group workspace received any kind of input (event worksapce, table workspace, md workspace, etc...). And it was able to group or ungroup correctly.

comment:21 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 8327

Note: See TracTickets for help on using tickets.