Ticket #7486 (closed: fixed)
Allow CompareMDWorkspaces to ignore BoxID-s
| Reported by: | Alex Buts | Owned by: | Alex Buts |
|---|---|---|---|
| Priority: | major | Milestone: | Release 2.6 |
| Component: | Framework | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Nick Draper |
Description
ConvertToMD and ConvertToDiffractionMDWorkspace assign mainly random box ID-s when run multi-threaded. To be able to compare two equivalent MD workspaces with only some box-id different, one needs the possibility to ignore box ID-s when comparing.
Change History
comment:2 Changed 7 years ago by Alex Buts
- Status changed from new to inprogress
refs #7486 Fixed missed ID comparison place
Changeset: 9ac408d8e94bf7a40cd2635a6d1a098bf4244072
comment:3 Changed 7 years ago by Alex Buts
refs #7486 Unit test for new comparison option.
Changeset: 7ba4e6de22dde327a4ccc891ad26c1e4754bef71
comment:4 Changed 7 years ago by Alex Buts
- Status changed from inprogress to verify
- Resolution set to fixed
should be pretty straightforward ticket to test.
CompareMDWorkspaces algorithm has new option, which allows it to ignore MD workspaces, which are equivalent but have different box-id-s assigned to boxes.
one can get such workspace by running ConvertToMDworkflow (#7485) in multithreaded mode (commenting line 23 of the test) or just go and run the code sample from ConvertToMD page.
Then one can compareMDWorkspaces and see that it fails if new option is not selected and passes if it is.
Unit test also gives good example of what have changed.
comment:6 Changed 7 years ago by Nick Draper
- Status changed from verify to verifying
- Tester set to Nick Draper
refs #7486 This should fix it
Changeset: 02a502e9de1d61b7566e0c8cfb4e49b1db5a351b