Ticket #7494 (closed: fixed)
ModeratorTzeroLinear minor tidy-ups
| Reported by: | Russell Taylor | Owned by: | Russell Taylor |
|---|---|---|---|
| Priority: | trivial | Milestone: | Release 3.0 |
| Component: | Framework | Keywords: | Maintenance |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Michael Reuter |
Description (last modified by Russell Taylor) (diff)
I initially thought that something about this algorithm was causing test failures, but in fact the problem is with LoadEventNexus & BASIS data. Still, there are some things that can be improved here.
Also, modify the unit test to not load real data.
Original description:
ModeratorTzeroLinearTest just started failing sometimes on our RHEL6 build. I've noticed that there are some thread-safety problems in an openmp block (input workspace taken as non-const and then dataX/Y/E called on it).
Change History
comment:1 Changed 7 years ago by Russell Taylor
- Priority changed from major to trivial
- Description modified (diff)
- Summary changed from ModeratorTzeroLinear thread safety fixes to ModeratorTzeroLinear minor tidy-ups
comment:3 Changed 7 years ago by Nick Draper
- Milestone changed from Release 2.6 to Backlog
Moved to the Backlog after the code freeze for R2.6
comment:5 Changed 7 years ago by Russell Taylor
- Keywords Maintenance added
- Description modified (diff)
comment:7 Changed 7 years ago by Russell Taylor
Re #7494. Improve handling of error conditions.
Changeset: d5b25a66ca2ab737f5ae345d8c1dad5d23c6e6ed
comment:8 Changed 7 years ago by Russell Taylor
Re #7494. Add tests that don't load data files.
Changeset: 850a8bf102b2f0bf684be23ae758178b7eb9d6f7
comment:9 Changed 7 years ago by Russell Taylor
Re #7494. Small tidy-ups in the algorithm.
Mostly the addition of const in several places.
Changeset: 3d1306f82fb727aadd2920100994af1fc62f8b55
comment:10 Changed 7 years ago by Russell Taylor
Re #7494. Remove tests that load data files.
The new non-loading tests should be sufficient.
Changeset: 9f931b934613788b02a22a9aeef8f852dee092f9
comment:11 Changed 7 years ago by Russell Taylor
- Status changed from inprogress to verify
- Resolution set to fixed
The main change here is removing the loading of a data file from the test (which I adapted from the ModeratorTZero test).
The only significant change in the algorithm is the making of the input workspace const. The results will be unaffected.
comment:12 Changed 7 years ago by Michael Reuter
- Status changed from verify to verifying
- Tester set to Michael Reuter
comment:13 Changed 7 years ago by Michael Reuter
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/7494_moderatorTZeroLinear_tidyups'
comment:14 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8339
