Ticket #7497 (closed: invalid)

Opened 7 years ago

Last modified 5 years ago

Move ISIS Refl Offspec scripts to API v2

Reported by: Mathieu Doucet Owned by: Mathieu Doucet
Priority: major Milestone: Release 2.6
Component: Python Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description (last modified by Mathieu Doucet) (diff)

Code in scripts/Reflectometry/offspec is still using API v1.

BEWARE: The original Offspec code is terribly written. I will not attempt to clean that code. I will only move it to the new API.

Change History

comment:1 Changed 7 years ago by Mathieu Doucet

  • Status changed from new to inprogress

Re #7497 Move algo calls to new API

Changeset: 9c7a749430d1823647b099955c46d20623aecbbd

comment:2 Changed 7 years ago by Mathieu Doucet

  • Description modified (diff)

comment:3 Changed 7 years ago by Mathieu Doucet

Re #7497 A little formatting so we can read the *%#$%@# code

Changeset: 57360121a2cf5edd6f14cdd21c57b3447e6ca572

comment:4 Changed 7 years ago by Mathieu Doucet

  • Status changed from inprogress to verify
  • Resolution set to fixed

To test:

  • This should be tested by somehow who knows the Offspec code and how to use it.
  • Check that the test pass and that there is no API v1 warning.
  • [optional] Talk to the original author and tell him how terrible this code is.

comment:5 Changed 7 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:6 Changed 7 years ago by Martyn Gigg

  • Status changed from verifying to reopened
  • Resolution fixed deleted

Rob actually wants these out of the distibution now and #7522 removed them there doesn't seem much point in modifying them anymore.

If I reopen this could we mark in invalid and then I'll pass the testing on that. Make it a but clearer that it wasn't merged

comment:7 Changed 7 years ago by Mathieu Doucet

  • Status changed from reopened to verify
  • Resolution set to invalid

comment:8 Changed 7 years ago by Martyn Gigg

  • Status changed from verify to verifying

comment:9 Changed 7 years ago by Martyn Gigg

  • Status changed from verifying to closed

Verified invalid as the code has been removed so nothing was merged.

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8342

Note: See TracTickets for help on using tickets.