Ticket #7499 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Replace FlatBackground with CalculateFlatBackground

Reported by: Martyn Gigg Owned by: Martyn Gigg
Priority: critical Milestone: Release 2.6
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Mathieu Doucet

Description

FlatBackground was deprecated in favour of CalculateFlatBackground and is causing warnings in many user scripts. CalculateFlatBackground was meant as a drop-in replacement so a simple replacement should do.

Change History

comment:1 Changed 7 years ago by Martyn Gigg

  • Status changed from new to inprogress

Replace FlatBackground with CalculateFlatBackground algorithm.

It was meant to be a drop-in replacement. Refs #7499

Changeset: 251349b540ee3265f26f2095ef7b24822a7beba3

comment:2 Changed 7 years ago by Martyn Gigg

Merge branch 'feature/7499_replace_flatbackground_with_calculateflatbackground' into develop

Refs #7499 Conflicts:

Code/Mantid/scripts/Inelastic/DirectEnergyConversion.py

Changeset: 1dd5d2a56384d82d492314ebcb7d7ae4a5ca4a60

comment:3 Changed 7 years ago by Martyn Gigg

  • Status changed from inprogress to verify
  • Resolution set to fixed

Branch: feature/7499_replace_flatbackground_with_calculateflatbackground

Tester: I have run all of the system tests manually on develop and none have failed so I assume this means CalculateFlatBackground is giving the same values as FlatBackground was. There are a couple of instances of FlatBackground left that are in bits of code already changed and not used in develop (sfCalculator) so I have not touched these as their usage will be removed anyway.

It would be good to test that the message doesn't show up in the Convert To Energy GUI. Start the interface, select IRIS as an instrument & go to the calib tab. Browse for an IRIS raw file (systemtests/Data) and click run on the tab. Inspect the results log and you should no longer see anything about a deprecated algorithm.

comment:4 Changed 7 years ago by Mathieu Doucet

  • Status changed from verify to verifying
  • Tester set to Mathieu Doucet

comment:5 Changed 7 years ago by Mathieu Doucet

Re #7499 There were a few missed calls to FlatBackground

Changeset: be11ac187b9fea0db1974760995de802a16dd136

comment:6 Changed 7 years ago by Mathieu Doucet

Re #7499 There were a few missed calls to FlatBackground

Changeset: 7ffcb4928fbedf1188de99a1914050415a7b55b7

comment:7 Changed 7 years ago by Mathieu Doucet

Re #7499 Fix minor conflict

Changeset: fd118fd2801f5e4b8230f26a29f50056fa2367c6

comment:8 Changed 7 years ago by Mathieu Doucet

  • Status changed from verifying to closed

Tested the Convert To Energy GUI to make sure the CalculateFlatBackground went through. Also checked the code changes.

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8344

Note: See TracTickets for help on using tickets.