SANS: Allow MASK/LINE width angle x y (easy to test)

[Anders Markvardsen]

Rob writes:

Sarah and I have been trying some new experiments on SANS2D and have found the need to tweak the masking process. Please find attached a version of isis_reduction_steps.py which allows an angled line to be placed in the mask with an arbitrary origin.

The command should now take

MASK/LINE width angle or MASK/LINE width angle x y

where x and y are in meters from the beam center.

I've checked that it works for both cases using the file attached. Could you modify the file in the main distribution and look at making sure that the two new bits of information appear in the mask table in the gui as well as modifying the documentation.

[Gesner Passos]

Extend the command MASK/LINE

now the command MASK/LINE accepts the following arguments:

WIDTH, ANGLE, X, Y

requested and suggested by Robert

re #7503

Changeset: c0c1ab06050fdca0a29cbbb19b852d2cdc9a7f24

[Gesner Passos]

Extend SANS interface to display MASK/LINE option

re #7503

Changeset: 1f91f3eda680cef4591f917f1cd70d4823f749b0

[Gesner Passos]

Add space to accommodate the LINE entry

small changes on SANSRunWindow.ui to adapt to the LINE showing more 2 parameters.

re #7503

Changeset: 06b3e2ba9c430a1b6c49e1c4574bf57b44bc5007

[Gesner Passos]

Tester:

• open ISIS INTERFACE
• change the instrument to SANS2D
• load the MASK FILE (the attached one)
• change to Masking Tab
• check that there is a row inside the table like: Arm | rear-detector | LINE 12.0 19.0 0.0 0.0599
• Click on Display mask
• You will see an image similar to the one attached. The red circle shows what the mask/line command has created.
• change parameters value inside file mask.txt line 37 from mask/line 12 19 0 0.0599 to your choice, and check that the arm line moves according to your option. (Make sure you reload the file through the interface - it does not recognize automatically that the file has changed)

[Gesner Passos]

It was critical just because I was short of time to implement it.

[Jay Rainey]

I had forgotten that a ticket should not be tested on the same day they are fixed.

[Nick Draper]

Moved to the Backlog after the code freeze for R2.6

[Gesner Passos]

Anders asked me to insert this for this release. As explained, and the code review can show, it preserves backward compatibility, so it won't break anything.

[Jay Rainey]

Merge remote-tracking branch 'origin/feature/7503_support_line_angle'

[Jay Rainey]

Testing

• Testing on Ubuntu 12.4.
• Information appear in the mask table in the GUI as expected.
• Masking line changes depending on mask set in file, as expected.

Code review

• Clean and consistent code.
• No visible bugs/problems.

[Stuart Campbell]

This ticket has been transferred to github issue ​8348