Ticket #7507 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Speed up Nexus Loaders

Reported by: Ricardo Leal Owned by: Ricardo Leal
Priority: major Milestone: Release 2.6
Component: Framework Keywords: ILL Loader
Cc: Blocked By:
Blocking: Tester: Nick Draper

Description

ILL and LLB Nexus loaders read data in the confidence method. This slowsdown the the Load.

Refactoring confidence method to use field names rather than load fields.

Change History

comment:1 Changed 7 years ago by Ricardo Leal

  • Status changed from new to inprogress

Speedup confidence method Re #7507

Changeset: 6d08585260105a2bd15b608accaf18327115ae1a

comment:2 Changed 7 years ago by Ricardo Leal

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:3 Changed 7 years ago by Ricardo Leal

Sort of difficult to verify... I loaded different files (default Loader) from all the instruments (ILL 4,5,6,D33, SINQ FOCUS, and LLB Mibemol) and it picks the right loader.

comment:4 Changed 7 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester set to Nick Draper

comment:5 Changed 7 years ago by Nick Draper

Code review is good, it does what is explained in the ticket.

Tested with LLB, PSI, and IN5 & D33 files to make sure correct loader was selected.

comment:6 Changed 7 years ago by Nick Draper

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/7507_SpeedUp_ILL_Loaders'

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8352

Note: See TracTickets for help on using tickets.