Ticket #7523 (closed: fixed)
LoadNexusProcessed cannot load partial event workspace
Reported by: | Wenduo Zhou | Owned by: | Federico M Pouzols |
---|---|---|---|
Priority: | blocker | Milestone: | Release 3.4 |
Component: | Framework | Keywords: | CORE |
Cc: | taylorrj@… | Blocked By: | |
Blocking: | #10619 | Tester: | Raquel Alvarez Banos |
Description
LoadNexusProcessed is not able to load partial EventWorkspace by specifying either the spectra range or a list of spectra. While it works for Workspace2D.
Change History
comment:3 Changed 6 years ago by Federico M Pouzols
- Status changed from assigned to inprogress
- Owner set to Federico M Pouzols
comment:5 Changed 6 years ago by Federico Montesino Pouzols
spectra-filtered EventWorkspace tests, skeleton, to be contd, re #7523
Changeset: a7b547998793c23761d06119fcda3962af0e6212
comment:6 Changed 6 years ago by Federico Montesino Pouzols
bring doc up-to-date re support of spectra filters, re #7523
Changeset: 74821fa97ffc0aeddfea6831a9fa953dd8ad9920
comment:7 Changed 6 years ago by Federico Montesino Pouzols
Support for partial event loading (spectra min, max, list), re #7523
Changeset: 045aee38172bea5db6324f9c3846c0595b7aeb4d
comment:8 Changed 6 years ago by Federico Montesino Pouzols
Tests for partial loading of event files, re #7523
Changeset: 27d636f975c30942b35375c8de650e7fde7c9b4d
comment:9 Changed 6 years ago by Federico Montesino Pouzols
clean and refactor common event tests, re #7523
Changeset: cd0f9c41ab955894d3c4c356ac5e4322afccf00c
comment:10 Changed 6 years ago by Federico Montesino Pouzols
and old repeated checks can go away, re #7523
Changeset: a748d1a9fe16d081a19943857865166c29605821
comment:11 Changed 6 years ago by Federico Montesino Pouzols
fix parameter names in doxygen doc, re #7523
Changeset: fc45320745b5cd6ef66020fb8615af89688a64ff
comment:12 Changed 6 years ago by Federico Montesino Pouzols
windoze: index variable in OpenMP for must have signed type, re #7523
Changeset: 6abdd51d6cd18ab94f1e59b2318efb8165b87928
comment:13 Changed 6 years ago by Federico Montesino Pouzols
and then avoid signed / unsigned comparison warning, re #7523
Changeset: 5608ae8cdd47ab6824e69be73fdb39f78434951e
comment:14 Changed 6 years ago by Federico Montesino Pouzols
typo fix in for loop, re #7523
Changeset: 31482d8d11df070c4f3f5a58458a6fb67ed1482b
comment:15 Changed 6 years ago by Federico M Pouzols
- Status changed from inprogress to verify
- Resolution set to fixed
This seems to be working well and without issues in systemtests. But a bit of in-depth testing here wouldn't hurt, as there seem to be a number of issues in this and related algorithms. I tried to strike a balance between cleaning/reorganizing the code and not breaking things that more or less work.
To test:
- check that unit tests pass. There's a bunch of new tests that check for different combinations of min, max, list of spectra with event NexusProcessed files. This especially concerns LoadRawSaveNxsLoadNxsTest and LoadNexusProcessedTest. Units tests have also been working well on the build servers.
- To double-check manually in a different setup, take a nexus file that can be loaded with LoadNexusProcessed (like testeventsort.nxs from AutoTestData/UsageData/), and use the min/max/list properties to make partial loads. Check that it works well. For example you can check basic properties: testeventsort.nxs is a "ToF" event file with 1000 events and 20 spectra, each containing 50 events. You can also check other details (using hdfview or similar, or any of your favorite files you're familiar with).
comment:16 Changed 6 years ago by Federico M Pouzols
- Status changed from verify to reopened
- Resolution fixed deleted
I'm reopening this until an issue with systemtests (ISIS_LETReduction) is cleared.
comment:17 Changed 6 years ago by Federico M Pouzols
The system test failure was a false alarm here. It was actually related to a different ticket (#8172).
For testing instructions, see #comment:15 above. The system tests have been running happily over the weekend but as said, this is a tricky part of the code, so please try to break it.
comment:18 Changed 6 years ago by Federico M Pouzols
- Status changed from reopened to verify
- Resolution set to fixed
comment:19 Changed 6 years ago by Raquel Alvarez Banos
- Status changed from verify to verifying
- Tester set to Raquel Alvarez Banos
comment:20 Changed 6 years ago by Federico Montesino Pouzols
fix includes after conflict merge, re #7523
Changeset: 476cca04bae06c51164d9ae6443377453dcd1680
comment:21 Changed 6 years ago by Federico M Pouzols
- Keywords CORE added
Added CORE keyword as suggested by Anders.
comment:22 Changed 6 years ago by Raquel Alvarez Banos
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/bugfix/7523_LoadNexusProcessed_cannot_load_partial_event_workspace'
Full changeset: d5326caf70635b265654cf80ef1b595ab8ce9d24
comment:23 Changed 6 years ago by Raquel Alvarez Banos
Merge remote-tracking branch 'origin/bugfix/7523_LoadNexusProcessed_cannot_load_partial_event_workspace'
Full changeset: d5326caf70635b265654cf80ef1b595ab8ce9d24
comment:24 Changed 5 years ago by Nick Draper
Somehow these slipped through without a resolution. Set to Fixed.
comment:25 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8368
Bulk move to assigned at the introduction of the triage step