Ticket #7528 (closed: worksforme)

Opened 7 years ago

Last modified 5 years ago

Debug level log in SmoothNeighbours needs a line break

Reported by: Keith Brown Owned by: Federico M Pouzols
Priority: trivial Milestone: Release 3.3
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: John Hill

Description

On windows, while testing #7441 and running the algorithm on CNCS_7860_event, a couple of the logs didn't have line breaks, see below.

Parameters:
  Name: InputWorkspace, Value: CNCS_7860_event, Default?: No, Direction: Input
  Name: OutputWorkspace, Value: 7860, Default?: No, Direction: Output
  Name: WeightedSum, Value: Flat, Default?: Yes, Direction: Input
  Name: Sigma, Value: 0.5, Default?: Yes, Direction: Input
  Name: IgnoreMaskedDetectors, Value: 0, Default?: No, Direction: Input
  Name: PreserveEvents, Value: 0, Default?: No, Direction: Input8 cores found. Performing sort with 1 cores per EventList, in 0 threads, using a chunk size of 320.

  Name: AdjX, Value: 1, Default?: Yes, Direction: Input
  Name: AdjY, Value: 1, Default?: Yes, Direction: Input
  Name: SumPixelsX, Value: 1, Default?: Yes, Direction: Input
  Name: SumPixelsY, Value: 1, Default?: Yes, Direction: Input
  Name: ZeroEdgePixels, Value: 0, Default?: Yes, Direction: Input
  Name: RadiusUnits, Value: Meters, Default?: Yes, Direction: Input
  Name: Radius, Value: 0, Default?: Yes, Direction: Input
  Name: NumberOfNeighbours, Value: 8, Default?: Yes, Direction: Input
  Name: SumNumberOfNeighbours, Value: 1, Default?: Yes, Direction: InputSmoothNeighbours processing NOT assuming rectangular detectors.

Read-locking CNCS_7860_event
Smoothing with Flat Weighting

However this is just in the log at debug level so it has no impact on the algorithm itself.

As the person who fixed #7441 was on Ubuntu, it is suspected it's due to the difference in end of line characters between platforms.

Change History

comment:1 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

bulk move to assigned at the into of the triage step

comment:2 Changed 6 years ago by Federico M Pouzols

  • Owner set to Federico M Pouzols
  • Status changed from assigned to verify
  • Resolution set to worksforme

I think this must have been fixed while working on other issues/tickets. I run SmoothNeighbors on the suggested file, with log level information and debug, and I get messages with correct new lines (there's also a new property ExpandSumAllPixels).

Note CNCS_7860_event.nxs is now included in the training course data.

comment:3 Changed 6 years ago by Federico M Pouzols

  • Milestone changed from Backlog to Release 3.3

comment:4 Changed 6 years ago by John Hill

  • Status changed from verify to verifying
  • Tester set to John Hill

comment:5 Changed 6 years ago by John Hill

  • Status changed from verifying to closed

comment:6 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 8373

Note: See TracTickets for help on using tickets.