Ticket #7545 (closed: fixed)
Use the more widely accepted definition of Lorentzian
| Reported by: | Martyn Gigg | Owned by: | Martyn Gigg |
|---|---|---|---|
| Priority: | blocker | Milestone: | Release 2.6 |
| Component: | Framework | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Arturs Bekasovs |
Description (last modified by Martyn Gigg) (diff)
We currently use height*(gamma2/(w2 + gamma2 )) where the more-widely accepted definition is given here:
http://mathworld.wolfram.com/LorentzianFunction.html
This was pointed out by Franz from the indirect group and is affecting the fits to their data.
For clarity we should use the more widely accepted definition.
Attachments
Change History
comment:7 Changed 7 years ago by Martyn Gigg
- Status changed from new to inprogress
Use the more-widely accepted definition of a Lorentzian function
Refs #7545
Changeset: e1a9a538ce8d55b193c27e10b33e312e630fe006
comment:8 Changed 7 years ago by Martyn Gigg
- Status changed from inprogress to verify
- Resolution set to fixed
Branch: feature/7545_move_lorentzian_to_widely_used_one
Tester: Use the ConvFit tab in the Indirect Data Analysis interface. The two files attached to the ticket will allow you to run a fit. You need to use the plotInput once the data files have been selected to set the starting parameters. You can then run the fit. Attached is a picture of the fit before the changes using 1 (left) & 2 (right) lorentzians. The fit using this definition is improved.
comment:9 Changed 7 years ago by Arturs Bekasovs
- Status changed from verify to verifying
- Tester set to Arturs Bekasovs
comment:5 Changed 7 years ago by Arturs Bekasovs
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/7545_move_lorentzian_to_widely_used_one'
comment:6 Changed 7 years ago by Arturs Bekasovs
Code changes seem to be reasonable and appropriate.
ConvFit works appropriately on the files provided. Fitted data looks like the one on the screenshot provided, with a slight difference which presumably represents the change in function definition. Is difficult to determine whether the fit is "better" than the old one, but is definitely not worse. No other behavioral changes noticed.
