Ticket #7547 (closed: fixed)
Remove API v1 usage in dgs_utils.py
| Reported by: | Russell Taylor | Owned by: | Russell Taylor |
|---|---|---|---|
| Priority: | critical | Milestone: | Release 2.6 |
| Component: | Direct Inelastic | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Nick Draper |
Description
Change History
comment:2 Changed 7 years ago by Russell Taylor
Merge branch 'feature/7547_dgs_utils_to_v2' into develop
Re #7547. Conflicts:
Code/Mantid/scripts/CMakeLists.txt
Changeset: 73506ebadf51b9c6bcfd8237babb0f88bc0167ac
comment:3 Changed 7 years ago by Russell Taylor
- Status changed from inprogress to verify
- Resolution set to fixed
The modified function is run when the DGS Reduction GUI is started up (or the instrument is changed) to load the instrument. There was a warning about v1 API use that will no longer be there (but notice that LoadEmptyInstrument is run). Info from the loaded instrument is then used to populate items in the GUI, for example the monitor indices. Check that this works for all instruments (SNS & ISIS). One small functional change is that the workspace from LoadEmptyInstrument is deleted rather than being kept as a hidden workspace. It is not used or required to be kept around as the instrument is stored in the InstrumentDataService.
comment:4 Changed 7 years ago by Nick Draper
- Status changed from verify to verifying
- Tester set to Nick Draper
comment:5 Changed 7 years ago by Nick Draper
Looks good. Tested using the installed version from develop
Re #7547. Move dgs_utils.py to python v2 API.
This was harder than foreseen because of all the unicode around here, which our Python API really doesn't like!
Changeset: 9bbf31bcebe830c98e2e91eaa2e9dfe66bc42178