MUON: writing/reading tempMuonAnalysisGrouping.xml causes bug

[Anders Markvardsen]

The MuonAnalysis interface currently save/reads information stored in a temporary file called tempMuonAnalysisGrouping.xml (see MuonAnalysis.cpp).

Recently it has been found that writing/reading this file causes mantid to fail when an user quickly from the Home tab manually scan through datasets.

This file contains grouping selection, displayed in Grouping Options tab.

As a first step see if we can have this file in memory rather than store to disk. This may turn out to be an easier fix than trying to figure out why a few PCs randomly fails.

For information tempMuonAnalysisGrouping.xml appears not to be used on startup of MuonAnalysis.

[Arturs Bekasovs]

Some stuff should be done before I can solve that one. When all the "Blocked by" tickets will get solved, I will be able to store all the information in GroupingWorkspace and string describing pairing, load and save all that information using LoadMuonDetectorsGroupingFile and SaveMuonDetectorsGrouping.

So instead of keeping the temporary file, when applying/saving grouping I will parse the information from the GUI to these data structures and use them instead.

[Arturs Bekasovs]

(In #7715) The Load one should output the list of names as another output parameter, and the Save one should accept it as an input parameter.

[Arturs Bekasovs]

All the stuff mentioned above turned out not to be that easy, because Muon Analysis uses a special case of grouping in the way that it allows one detector to be in multiple groups. It's too late to start resolving these issues this iteration, hence I'll leave them for now. However, the bug should certainly be solved for this release, but I'll do it in a different way - I'll try to use the possibility to specify custom spectra IDs for GroupDetectors, use it for every group and then just merge the results to one workspace.

[Arturs Bekasovs]

All the stuff mentioned above turned out not to be that easy, because Muon Analysis uses a special case of grouping in the way that it allows one detector to be in multiple groups. It's too late to start resolving these issues this iteration, hence I'll leave them for now. However, the bug should certainly be solved for this release, but I'll do it in a different way - I'll try to use the possibility to specify custom spectra IDs for GroupDetectors, use it for every group and then just merge the results to one workspace.

[Arturs Bekasovs]

New functions to interact with tables and XML files.

Plus removed old ones and tmp file usage. Grouping is not applied properly yet.

Refs #7557

Changeset: c28ec3aea2dd4603b839de8dbeeca2e5fbe3679e

[Arturs Bekasovs]

Updated function to apply grouping.

Not working for group workspaces yet.

Refs #7557

Changeset: b20ff519f0402cbb2d29842709348e61180798b6

[Arturs Bekasovs]

Additional check for AsymmetryCalc.

Normally, this shouldn't happen, but it will help to identify problem when it does.

Refs #7557

Changeset: 855a27c15da320b30488423cb4e1e14060cf9850

[Arturs Bekasovs]

Don't fill up pair combo-boxes manually when filling table.

This will be done in a slot, when group table is changed.

Refs #7557

Changeset: 0fe75a255e8e45e135af16e5bc393e6ab62d366e

[Arturs Bekasovs]

One more should be here:

Refactored applyGroupingToWS and made it to work with groups.

Refs #7557

Changeset: 379c3c2e5ad4ba0a89bfdf98f2d4168f52ade717

[Arturs Bekasovs]

Added DLL export macros to functions.

Windows fails to use them in other files otherwise.

Refs #7557

Changeset: 235c1ec636f6a9126badaad5dce962a07db72f20

[Arturs Bekasovs]

Fix build errors because of not included file.

Plus improve code layout.

Refs #7557

Changeset: dbcdbe9cad3fc766eae9288530adcfe78e7cc32e

[Arturs Bekasovs]

Fix build error on OS X due to incorrect constructor param type.

Refs #7557

Changeset: 4c64d061d0a94d2e0a6e85a4d8571dbe3ef36693

[Arturs Bekasovs]

Fixed the problem being unable to load more ws if group loading failed.

Refs #7557

Changeset: ae512fb1584d2f7dab60f268e32be07a42cc55f6

[Arturs Bekasovs]

Tester:

All in all, in this ticket I've changed the way GUI <-> Grouping <-> XML file interact with each other, and the way grouping is applied to a workspace.

The main aim was not to use temporary file for storing/applying grouping, so please check it was removed from everywhere in MuonAnalysis.cpp.

Verify that custom grouping saving/loading was not broken:

1. Load some data file.
2. Go to Grouping tab and change the information in there. Make sure you:
   • Add some groups with custom names and detector IDs
   • Add some pairs with custom names and your own added groups
   • Change the description
3. Now using appropriate button at the top save this grouping to some file.
4. Restart MuonAnalysis interface.
5. Load the same data file.
6. Go to Grouping tab and load previously saved grouping file. Make sure it all was properly loaded.
7. Try to plot your own groups and pairs to make sure they are not just symbols on the screen. Try to change detector IDs/pair groups and check that plots are changing in that case.
8. Additionally, try to load a file which is not a grouping file, and make sure that error is displayed and none of the information is overwritten.

Now the only thing left to check is that grouping is applied properly. To do that I've made screenshots of some plots created using MuonAnalysis in MantidPlot 2.6. Your task is to load appropriate data files using MuonAnalysis, plot the only pair in there and compare the results. This will verify that (at least) testing files for all the Muon instruments are grouped correctly.

Data files used to make screenshots:

• AutoTestData/MUSR00015189.nxs
• AutoTestData/argus0026287.nxs
• AutoTestData/emu00006473.nxs
• SystemTests/Data/hifi00038401.nxs

[Arturs Bekasovs]

argus0026287.nxs

[Arturs Bekasovs]

emu00006473.nxs

[Arturs Bekasovs]

MUSR00015189.nxs

[Arturs Bekasovs]

hifi00038401.nxs

[Roman Tolchenov]

Merge remote-tracking branch 'origin/feature/7557_muon_rm_tmp_file'

Full changeset: ​7f5492fc55112fcb1806378243e7ffd19ff2ac63

[Stuart Campbell]

This ticket has been transferred to github issue ​8402