[IDA] ConvFit - File paths on Linux/Mac cause a crash

[Samuel Jackson]

The IDA ConvFit tab can crash Mantid when a file has been selected using the file browser. There's a suspicion that this is caused by the difference in file paths between Windows and Mac/Linux.

To reproduce:

• Put irs26174_graphite002_red.nxs and irs26173_graphite002_res.nxs found in the sample data into a file path that Mantid can find.
• Open the IDA interface and go to ConvFit
• Put the file names (without the path) into each of the boxes.
• Set the following parameters:
  • Tick plot guess
  • Fit type: 1 Lorenzian
  • StartX: -0.5, EndX: 0.5, Amplitude: 50
• Hit run and watch it crash

Leaving in the full file path stops it from crashing, but running sequential fit with the same parameters will cause the following error:

ValueError: Invalid value for property Function (Function) "name=LinearBackground,A0=0.0,A1=0,ties=(A0=0.0,A1=0.0);(composite=Convolution;name=Resolution, FileName=/home/chs18285/Downloads/irs26173_graphite002_res.nxs;(name=Lorentzian,Height=5.63805,PeakCentre=-0.001071,HWHM=0.01426))": Error in input string to FunctionFactory
name=LinearBackground,A0=0.0,A1=0,ties=(A0=0.0,A1=0.0);(composite=Convolution;name=Resolution, FileName=/home/chs18285/Downloads/irs26173_graphite002_res.nxs;(name=Lorentzian,Height=5.63805,PeakCentre=-0.001071,HWHM=0.01426))
  at line 14 in '<Interface>'
  caused by line 204 in '/opt/Mantid/scripts/Inelastic/IndirectDataAnalysis.py'
  caused by line 115 in '/opt/Mantid/scripts/Inelastic/IndirectDataAnalysis.py'
  caused by line 185 in '/opt/Mantid/bin/mantid/simpleapi.py'

[Samuel Jackson]

This issue appears to have been fixed through other tickets. To verify, try running ConvFit with the given parameters. It appears to no longer crash.

[Michael Reuter]

I had to use irs26176_graphite002_red.nxs as the other file isn't available, but this is crashing on Ubuntu, OSX and Windows with the latest master build. I seem to be getting the crashes when I try to set the StartX value in the GUI.

[Samuel Jackson]

Added auto searching to RES file.

Also added exception to catch invalid input.

Refs #7559

Changeset: d80916609389448648b2763d8b3bdf0feaa5d396

[Samuel Jackson]

To Test

Rerun the test in the ticket description with any *_red/*_res file you like. The problem was with the *_res file path validation so pay extra attention to ensuring this works by passing it different combinations of valid and invalid files.

[Michael Reuter]

This looks to be working now.

[Michael Reuter]

Merge remote-tracking branch 'origin/feature/7559_ConvFit_filepath_crash'

[Stuart Campbell]

This ticket has been transferred to github issue ​8404