Ticket #7573 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Preferences should be reviewed and defaults fixed

Reported by: Keith Brown Owned by: Dan Nixon
Priority: minor Milestone: Release 3.3
Component: GUI Keywords:
Cc: Blocked By:
Blocking: Tester: Nick Draper

Description (last modified by Keith Brown) (diff)

Some of the preferences may not actually be used, and if they are still used they should have their default set appropriately for the system it's installed on.

Example: Preferences -> General -> Endline character
This option defaults to "LF (Unix)" even on a windows system. Martyn Giggs mentioned that this property might not even be used. If that property is used it should default to the appropriate system Mantid is installed on and if it's not used it should be removed.

All the properties should have this done for them in order to remove redundant options.

Change History

comment:1 Changed 7 years ago by Keith Brown

  • Description modified (diff)

comment:2 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

bulk move to assigned at the into of the triage step

comment:3 Changed 6 years ago by Dan Nixon

  • Owner set to Dan Nixon

comment:4 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Cleaned up default separator and newline preferences

Both import and export ASCII use same newline and column separator values from preference window

Windows newline should default to CRLF

Refs #7573

Changeset: 1a1d1c177898c922f7b34c8b6321e675e852fa84

comment:5 Changed 6 years ago by Dan Nixon

So far have tested everything under General, Tables, 2D Plots and 3D Plots.

Almost all settings under there seem to be working (at the very least they update the settings of another system (e.g. antialiasing seems to do very little but is being enabled/disabled)).

Still to test:

  • Mantid/Curve Fitting
Last edited 6 years ago by Dan Nixon (previous) (diff)

comment:6 Changed 6 years ago by Dan Nixon

  • Milestone changed from Backlog to Release 3.3

comment:7 Changed 6 years ago by Dan Nixon

Correct fix for setting CRLF as default EOL on Windows

Refs #7573

Changeset: ac5eccc21c313d854f8eb10508c1b0f46b15a6a8

comment:8 Changed 6 years ago by Dan Nixon

Added some tool tips for less intuitive preferences

Refs #7573

Changeset: 8cb133aded582849265213b140af79b9cdb83a71

comment:9 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

Import and Export ASCII now get their EOL value from that defined in preferences.

All other preferences are at least used to set a value in a different system.

comment:10 Changed 6 years ago by Nick Draper

  • Status changed from verify to verifying
  • Component changed from Framework to User Interface
  • Tester set to Nick Draper

comment:11 Changed 6 years ago by Nick Draper

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/7573_review_preferences'

Full changeset: 45a5461aa9513c5016810a1a05e7ac0240dcf1a9

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 8418

Note: See TracTickets for help on using tickets.