Ticket #7574 (closed: fixed)
Show detectors allows value editing
Reported by: | Keith Brown | Owned by: | Federico M Pouzols |
---|---|---|---|
Priority: | minor | Milestone: | Release 3.4 |
Component: | Framework | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Karl Palmen |
Description
Show detectors is allowing users to change values in the window, but it's not saving them on close and is restoring the original values when it's restored.
This is good as it doesn't allow actual value editing but it should be even more water-tight.
The table should be made read-only so that even if the values aren't saved they shouldn't be editable in the first place.
Change History
comment:2 Changed 7 years ago by Nick Draper
- Status changed from new to assigned
bulk move to assigned at the into of the triage step
comment:3 Changed 6 years ago by Federico M Pouzols
- Status changed from assigned to inprogress
- Owner set to Federico M Pouzols
comment:4 Changed 6 years ago by Federico Montesino Pouzols
create detectors tables as read-only, re #7574
Changeset: 32005545baed383c699adf3fdb4c0d5a0a8ec368
comment:5 Changed 6 years ago by Federico Montesino Pouzols
slight change of bkg color so current cell is visible, re #7574
Changeset: 5a5a8ed853b2d865ea790e2916da4bf667bff438
comment:6 Changed 6 years ago by Federico M Pouzols
- Status changed from inprogress to verify
- Resolution set to fixed
- Milestone changed from Backlog to Release 3.4
The MantidUI::createDetectorsTable() method has been modified so that the detectors table is marked as read only (all its columns). There are however a few oddities:
- Qti tables do this in a way that I find very odd/counterintuitive: you still get actions like "cut", "set column values", etc. but if you try to use them you'll be shown a warning message telling that the cells/columns are read-only.
- Also note that because the detector table is a qti Table / MyTable / Q3Table, you can still right-click on a column and do "Set As -> Read only" to set a column back to read/write mode.
I guess we just stick to qti Table for now, as this would be an extremely minor priority issue.
To test: open the detectors table for a few of your favorite workspaces and double-check that you cannot edit the table. You can open the detectors table for a workspace by either right click->"Show Detectors", or right click->Show data then right-click on the data -> "View detectors table".
comment:7 Changed 6 years ago by Wenduo Zhou
- Status changed from verify to verifying
- Tester set to Wenduo Zhou
comment:8 Changed 6 years ago by Federico M Pouzols
- Status changed from verifying to reopened
- Resolution fixed deleted
I'm reopening the ticket, as an issue has been found with the detector table background color. It needs to be corrected before this ticket is tested.
comment:9 Changed 6 years ago by Federico Montesino Pouzols
- Status changed from reopened to inprogress
keep default as black text on white bkg, re #7574
Changeset: 6995ad9aa158289bb97d062ab4d322320bfe118f
comment:10 Changed 6 years ago by Federico M Pouzols
- Status changed from inprogress to verify
- Resolution set to fixed
To test: follow instructions in comment:6
comment:11 Changed 6 years ago by Karl Palmen
- Status changed from verify to verifying
- Tester changed from Wenduo Zhou to Karl Palmen
comment:12 Changed 6 years ago by Federico Montesino Pouzols
- Status changed from verifying to closed
Merge branch 'master' into bugfix/7574_show_detectors_allows_value_editing
Full changeset: 4bd41c47214ddab37855c4241fd2485c32c9ca21
comment:13 Changed 6 years ago by Karl Palmen
Merge remote-tracking branch 'origin/bugfix/7574_show_detectors_allows_value_editing'
Full changeset: 2dafa20591885114f5355bb55ffe92219872521d
comment:14 Changed 5 years ago by Nick Draper
Somehow these slipped through without a resolution. Set to Fixed.
comment:15 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8419
If this doesn't happen with all workspaces it has happened with BSS_13387_event.nxs at least