Show detectors allows value editing

[Keith Brown]

Show detectors is allowing users to change values in the window, but it's not saving them on close and is restoring the original values when it's restored.

This is good as it doesn't allow actual value editing but it should be even more water-tight.

The table should be made read-only so that even if the values aren't saved they shouldn't be editable in the first place.

[Keith Brown]

If this doesn't happen with all workspaces it has happened with BSS_13387_event.nxs at least

[Nick Draper]

bulk move to assigned at the into of the triage step

[Federico Montesino Pouzols]

create detectors tables as read-only, re #7574

Changeset: 32005545baed383c699adf3fdb4c0d5a0a8ec368

[Federico Montesino Pouzols]

slight change of bkg color so current cell is visible, re #7574

Changeset: 5a5a8ed853b2d865ea790e2916da4bf667bff438

[Federico M Pouzols]

The MantidUI::createDetectorsTable() method has been modified so that the detectors table is marked as read only (all its columns). There are however a few oddities:

• Qti tables do this in a way that I find very odd/counterintuitive: you still get actions like "cut", "set column values", etc. but if you try to use them you'll be shown a warning message telling that the cells/columns are read-only.
• Also note that because the detector table is a qti Table / MyTable / Q3Table, you can still right-click on a column and do "Set As -> Read only" to set a column back to read/write mode.

I guess we just stick to qti Table for now, as this would be an extremely minor priority issue.

To test: open the detectors table for a few of your favorite workspaces and double-check that you cannot edit the table. You can open the detectors table for a workspace by either right click->"Show Detectors", or right click->Show data then right-click on the data -> "View detectors table".

[Federico M Pouzols]

I'm reopening the ticket, as an issue has been found with the detector table background color. It needs to be corrected before this ticket is tested.

[Federico Montesino Pouzols]

keep default as black text on white bkg, re #7574

Changeset: 6995ad9aa158289bb97d062ab4d322320bfe118f

[Federico M Pouzols]

To test: follow instructions in comment:6

[Federico Montesino Pouzols]

Merge branch 'master' into bugfix/7574_show_detectors_allows_value_editing

Full changeset: ​4bd41c47214ddab37855c4241fd2485c32c9ca21

[Karl Palmen]

Merge remote-tracking branch 'origin/bugfix/7574_show_detectors_allows_value_editing'

Full changeset: ​2dafa20591885114f5355bb55ffe92219872521d

[Nick Draper]

Somehow these slipped through without a resolution. Set to Fixed.

[Stuart Campbell]

This ticket has been transferred to github issue ​8419