Ticket #7596 (closed: fixed)
If Matrix dimemsions are set too large Mantid does nothing
Reported by: | Karl Palmen | Owned by: | Raquel Alvarez Banos |
---|---|---|---|
Priority: | major | Milestone: | Release 3.4 |
Component: | Framework | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Federico M Pouzols |
Description
It would be better in such a case for Mantid to give a message stating that the dimensions are too large and better still state the maximum dimensions.
Change History
comment:2 Changed 6 years ago by Raquel Alvarez Banos
- Owner set to Raquel Alvarez Banos
- Status changed from assigned to inprogress
comment:4 Changed 6 years ago by Raquel Alvarez Banos
Also noticed the following issue:
New Matrix -> Set Values, now set "For row" and "For col" from 1 to a large number. Mantid shows an error message stating that dimensions are too large and then crashes.
comment:5 Changed 6 years ago by Raquel Alvarez Banos
Both issues should be fixed now.
For tester:
- Create a matrix
- Matrix -> Set Dimensions... Try setting "Rows" and "Columns" to a large number. You should get an error message stating that dimensions are too large.
- Matrix -> Set Values... Enter a large number in "For row (i)" and "For col (j)" fields (you will also have to provide a formula for "Cell(i,j)"). You should get an error message stating that dimensions are too large.
- Check that other features (Transpose, Flip, Invert, Determinant, ...) work properly.
comment:6 Changed 6 years ago by Raquel Alvarez Banos
Re #7596 Setting max dimensions and adding error message
Changeset: 8c258088bfa0e8c8c147b6439b12fe519f1f2e3a
comment:7 Changed 6 years ago by Raquel Alvarez Banos
Re #7596 original values in qspinbox
Changeset: 3c4f7ffd97e5306ba0cd1cbb53cd95aa4892c6c9
comment:8 Changed 6 years ago by Raquel Alvarez Banos
Re #7596 Stating max dimensions
Changeset: f2aedcd51944c6cda0768cc7d57f409c46ef6276
comment:9 Changed 6 years ago by Raquel Alvarez Banos
Re #7596 fixing SetValues issue
Changeset: dae25251c8fc40030d7de0ea1fb5d7ff84019c0b
comment:10 Changed 6 years ago by Raquel Alvarez Banos
Re #7596 Fixing to_string issue
Changeset: 5cc8d1c0cf26aaea060d671f3b8bac14139cd42a
comment:11 Changed 6 years ago by Raquel Alvarez Banos
- Status changed from inprogress to verify
- Resolution set to fixed
comment:12 Changed 6 years ago by Federico M Pouzols
- Status changed from verify to verifying
- Tester set to Federico M Pouzols
comment:13 Changed 6 years ago by Federico M Pouzols
I'm getting this error:
ERROR: Branch 'bugfix/7596_bugfix_large_matrix_dimensions' has not been fully merged to develop, meaning it is not possible to know whether the code is valid on all environments.
It seems that you need to do a checkbuild with the latest commits?
comment:14 Changed 6 years ago by Federico M Pouzols
- Status changed from verifying to closed
An error is shown if you specify huge dimensions, and this prevents Mantid from silently doing nothing or crashing. Everything else in Matrices seems to work well.
comment:15 Changed 6 years ago by Federico Montesino Pouzols
Merge remote-tracking branch 'origin/bugfix/7596_bugfix_large_matrix_dimensions'
Full changeset: 414264c90a3d818ac93e51158c7b40b20fec62bd
comment:16 Changed 5 years ago by Nick Draper
Somehow these slipped through without a resolution. Set to Fixed.
comment:17 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8441
Bulk move to assigned at the introduction of the triage step