Ticket #7605 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Fix hard-coded expectations from CreateGroupingWorkspaceTest

Reported by: Martyn Gigg Owned by: Martyn Gigg
Priority: blocker Milestone: Release 2.6
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Gesner Passos

Description

This test currently hard codes the number of expected spectra in the output workspace. A recent change in the POWGEN IDF, which only came into effect at a later date, caused the test to fail as the number of detectors had changed.

The algorithm creates a workspace that has the same number of spectra as detectors so a more flexible check would just be to verify this against the instrument.

Change History

comment:1 Changed 7 years ago by Martyn Gigg

  • Status changed from new to inprogress

Remove hard-coded numbers from CreateGroupingWorkspaceTest.

It now just checks against the number of detectors in the instrument. Refs #7605

Changeset: 5bd7ea0453d76e724642788bc0df9f6158f15484

comment:2 Changed 7 years ago by Martyn Gigg

  • Status changed from inprogress to verify
  • Resolution set to fixed

Branch: bugfix/7605_CreateGroupingWorkspaceTest_fix

Tester: Build the AlgorithmsTest suite and run the CreateGroupingWorkspaceTest before and after the changes. It should fail before and pass now.

comment:3 Changed 7 years ago by Gesner Passos

  • Status changed from verify to verifying
  • Tester set to Gesner Passos

comment:4 Changed 7 years ago by Gesner Passos

This effectively solves the issue.

comment:5 Changed 7 years ago by Gesner Passos

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/7605_CreateGroupingWorkspaceTest_fix'

comment:6 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8450

Note: See TracTickets for help on using tickets.