Ticket #7607 (closed: fixed)
Remove v1 PythonAPI
Reported by: | Martyn Gigg | Owned by: | Martyn Gigg |
---|---|---|---|
Priority: | blocker | Milestone: | Release 3.0 |
Component: | Python | Keywords: | |
Cc: | Blocked By: | #7690 | |
Blocking: | Tester: | Peter Peterson |
Description
The timeline for removal was 3.0 so it will be gone!
Change History
comment:3 Changed 7 years ago by Martyn Gigg
Check for v2 Python API in systemtests setup.
Refs #7607
Changeset: a7a8da564028950037ec39674cf0643f263173c8
comment:3 Changed 7 years ago by Martyn Gigg
- Status changed from new to inprogress
Rename downcast_returned_value to DowncastReturnedValue ...
to be consistent coding/naming guidelines. Refs #7607
Changeset: 47c1b6fc4f34d756a4975614eeaa63342caddef1
comment:4 Changed 7 years ago by Martyn Gigg
Fix MatrixWorkspace::detectorTwoTheta methods
Refs #7607
Changeset: d9837b267048d3358ce891b6dab5ea5e406c0d87
comment:5 Changed 7 years ago by Russell Taylor
I assume these RHEL6 compiler warnings relate to this ticket:
from /home/builder/jenkins/workspace/ornl_clean_rhel6_develop/Code/Mantid/Framework/PythonInterface/mantid/kernel/src/Exports/VMD.cpp:2: /home/builder/jenkins/workspace/ornl_clean_rhel6_develop/Code/Mantid/Framework/Kernel/inc/MantidKernel/VMD.h: In member function ‘PyObject* boost::python::objects::caller_py_function_impl<Caller>::operator()(PyObject*, PyObject*) [with Caller = boost::python::detail::caller<Mantid::Kernel::VMD_t (*)(const Mantid::Kernel::VMD&, size_t), boost::python::default_call_policies, boost::mpl::vector3<float, const Mantid::Kernel::VMD&, long unsigned int> >]’: /home/builder/jenkins/workspace/ornl_clean_rhel6_develop/Code/Mantid/Framework/Kernel/inc/MantidKernel/VMD.h:272: warning: dereferencing pointer ‘p.851’ does break strict-aliasing rules /home/builder/jenkins/workspace/ornl_clean_rhel6_develop/Code/Mantid/Framework/Kernel/inc/MantidKernel/VMD.h:271: warning: dereferencing pointer ‘p.851’ does break strict-aliasing rules /home/builder/jenkins/workspace/ornl_clean_rhel6_develop/Code/Mantid/Framework/Kernel/inc/MantidKernel/VMD.h:271: warning: dereferencing pointer ‘p.851’ does break strict-aliasing rules
comment:6 Changed 7 years ago by Martyn Gigg
Copy the bundled Python distribution to the build dirs on windows.
All of the code surrounding the bunding has been move to a new file that handles both the dev versions and bundling for the final package. Refs #7607
Changeset: b1f46e2f8cd15a35501b30fa422e798f801e6f1e
comment:7 Changed 7 years ago by Martyn Gigg
Fix aliasing warnings on gcc4.4 in release mode.
It seem to be related to taking const & arguments for wrapped functions. The const really offered nothing as it is cast away under the surface by the wrappers anyway... Refs #7607
Changeset: c272ff0873b7067c816cc5659a00a5c6e61b568b
comment:8 Changed 7 years ago by Martyn Gigg
Fix aliasing warnings on gcc4.4 in release mode.
It seem to be related to taking const & arguments for wrapped functions. The const really offered nothing as it is cast away under the surface by the wrappers anyway... Refs #7607
Changeset: d0cffa29be1644337327c8c58e581481275ba295
comment:9 Changed 7 years ago by Martyn Gigg
Remove final parts of PythonAPI directory. Refs #7607
Changeset: 41a84181952ff8be83017426f6bca61aa46f4aae
comment:10 Changed 7 years ago by Martyn Gigg
- Status changed from inprogress to verify
- Resolution set to fixed
Branch: feature/7607_remove_v1_python_api in BOTH main code & systemtests repository
Tester: The directory Code/Mantid/Framework/PythonAPI should be gone in the repository on github (you will still have a local one since there will be pyc files left from old PythonAlgorithms) The code should build cleanly and MantidPlot should start with no errors or warnings. The warning about v1 disappearing should be gone.
The systemtests on all platforms should be passing too.
The packages from the clean develop builds on all platforms should be checked to see that Mantid at least starts up and there is nothing missing from the packages.
comment:11 Changed 7 years ago by Peter Peterson
- Status changed from verify to verifying
- Tester set to Peter Peterson
comment:12 Changed 7 years ago by Peter Peterson
Things I have tried:
- Building locally (RHEL6) and running some python algorithms and system tests
- Running installed develop clean build on RHEL6 (powgen)
- Running installed develop clean build on OSX 10.8
- Running installed develop clean build on Win7 (64bit)
comment:13 Changed 7 years ago by Peter Peterson
- Status changed from verifying to closed
Merge remote branch 'origin/feature/7607_remove_v1_python_api'
comment:14 Changed 7 years ago by Peter Peterson
Merge remote branch 'origin/feature/7607_remove_v1_python_api'
comment:15 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8452