Ticket #7644 (closed: fixed)
Remove Deprecation of CreateCalFileByNames, ReadGroupsFromFile and CreateDummyCalFile
| Reported by: | Nick Draper | Owned by: | Karl Palmen |
|---|---|---|---|
| Priority: | blocker | Milestone: | Release 3.0 |
| Component: | Framework | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #7072 | Tester: | Russell Taylor |
Description
The ISIS scientists still use cal files exclusively and have no desire to change to masking and grouping workspaces.
Change History
comment:1 Changed 7 years ago by Nick Draper
- Summary changed from Remove Deprecation of CreateCalFile By names to Remove Deprecation of CreateCalFileByNames and CreateDummyCalFile
comment:2 Changed 7 years ago by Nick Draper
- Summary changed from Remove Deprecation of CreateCalFileByNames and CreateDummyCalFile to Remove Deprecation of CreateCalFileByNames, ReadGroupsFromFile and CreateDummyCalFile
comment:5 Changed 7 years ago by Karl Palmen
Remove deprecation and update wiki re #7644
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: f50132a782e59fe71c5b315a7cce1a75eceaf4fc
comment:6 Changed 7 years ago by Karl Palmen
- Status changed from inprogress to verify
- Resolution set to fixed
To test, run Mantid, check that the algorithms are available in trhe diffraction category execute each algorithm, see that there is no deprecation message on the dialog box or when run. Check that there is no deprecation in the wiki documentation of these algorithms.
comment:7 Changed 7 years ago by Russell Taylor
- Status changed from verify to verifying
- Tester set to Russell Taylor
comment:8 Changed 7 years ago by Russell Taylor
- Status changed from verifying to reopened
- Resolution fixed deleted
The functional testing passes OK. Just a couple of things to tidy up:
- Please remove the inclusion of DeprecatedAlgorithm.h in the algorithm headers.
- Remove these algorithms from the Deprecated wiki category (edit the bottom of each wiki page)
comment:10 Changed 7 years ago by Karl Palmen
For testing it is necessary to run wikimaker, if it has not been done earlier the same day, else the out of date master wiki will have been put into place.
comment:11 Changed 7 years ago by Karl Palmen
Remove inclusions of DeprecatedAlgorith.h re #7644
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 4f593255c3b7af944bd034ee46285b15bda6758f
comment:12 Changed 7 years ago by Karl Palmen
- Status changed from inprogress to verify
- Resolution set to fixed
I've run wikimaker on the three algorithms for testing today.
comment:14 Changed 7 years ago by Russell Taylor
- Status changed from verifying to closed
The ReadGroupsFromFile wiki isn't updated yet but I can see that it's going to work.
comment:15 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8489
